Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for SketchUp 2024 #714

Merged
merged 33 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
bfcf310
Updates for SketchUp 2024
macumber May 17, 2024
377c9d3
One more File.exists
jmarrec May 17, 2024
48d1f9d
Fixup looking for system ruby for running tests
jmarrec May 17, 2024
50f155a
Use same major and minor version of Qt as SketchUp
macumber May 18, 2024
2751769
Don't run workflow if PR is draft
macumber May 18, 2024
f0b8a25
Trigger CI when PR is marked ready for review
macumber May 19, 2024
598c17d
Update to official 3.8.0 packages
macumber May 19, 2024
fff53cf
Update resources
macumber May 20, 2024
55cfab6
Update .github/workflows/app_build.yml
jmarrec May 21, 2024
6473833
Unrelated update AboutBox and model_editor fallbacks for Qt6
jmarrec May 23, 2024
d4f56e7
Allow passing QT_VERSION (default 6.5.3) - Update Qt version in about…
jmarrec May 23, 2024
ae7730b
Make Ruby3 compatible
macumber May 25, 2024
b70a120
Try calling automationmodetool
macumber May 25, 2024
d86d19f
Fix some bugs
macumber May 26, 2024
4ef58a9
Merge branch 'sketchup_2024' of github.com:openstudiocoalition/OpenSt…
macumber May 26, 2024
7d30090
clang format
macumber May 26, 2024
addfaf0
Try the gtest/QApplication workaround
macumber May 26, 2024
4e1dee8
Missed this file
macumber May 26, 2024
f35dda7
Apply fix to benchmark as well, remove PathWatcher support for direct…
macumber May 26, 2024
5dea4d3
Clean up documentation
macumber May 26, 2024
427d60d
Clang format
macumber May 26, 2024
03018ef
Move to Qt 6.5.2
macumber May 26, 2024
1157124
Fix ruby test
macumber May 26, 2024
fbe0d12
Merge branch 'sketchup_2024' of github.com:openstudiocoalition/OpenSt…
macumber May 26, 2024
dbaa0c4
Try to fix tests on Ubuntu
macumber May 26, 2024
6e95292
libxcb -> libxcb-icccm4
macumber May 27, 2024
67dac8d
More libxcb
macumber May 27, 2024
4ac00c2
Remove missing packages
macumber May 27, 2024
1d8597a
Use versions that exist
macumber May 27, 2024
ff6c20e
Temp disable other platforms to get remaining libxcb issues
macumber May 27, 2024
051b028
Add libxcb-shape
macumber May 27, 2024
4cd5ac0
Finally got tests working on Ubuntu
macumber May 27, 2024
808ff08
Merge branch 'develop' into sketchup_2024
macumber May 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,16 @@ endif()
# Qt
# e.g. QT_INSTALL_DIR = C:/Qt/6.5.3/msvc2019_64
set(QT_INSTALL_DIR "" CACHE PATH "Path to Qt Install")
set(QT_VERSION "6.5.3")
set(QT_VERSION "6.5.3" CACHE STRING "Qt target version, defaults to 6.5.3")

# For AboutBox, but also validates that the version is valid
string(REGEX MATCH "^([0-9]+\\.[0-9]+)"
QT_VERSION_MAJOR_MINOR ${QT_VERSION})
if(NOT QT_VERSION_MAJOR_MINOR)
message(FATAL_ERROR "Failed to match QT_VERSION=${QT_VERSION}")
endif()
set(QT_DOC_LINK "https://doc.qt.io/qt-${QT_VERSION_MAJOR_MINOR}/qtmodules.html")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow passing QT_VERSION... default to 6.5.3

Make a link for the aboutbox



# TODO: how to set OPENSSL_ROOT_DIR to a generator expression?
set(OPENSSL_ROOT_DIR ${CONAN_OPENSSL_ROOT_RELEASE})
Expand Down
6 changes: 3 additions & 3 deletions ruby/openstudio_modeleditor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ module WinAPI
qt_dll_path = File.expand_path(File.join(File.dirname(__FILE__), '../bin/'))

# if install path fails, try developer paths
if !File.exist?(File.join(qt_dll_path, 'Qt5Core.dll'))
if !File.exists?(File.join(qt_dll_path, 'Qt6Core.dll'))
release_dll_path = File.expand_path(File.join(File.dirname(__FILE__), '../../Release/'))
debug_dll_path = File.expand_path(File.join(File.dirname(__FILE__), '../../Debug/'))
if File.exist?(File.join(release_dll_path, 'Qt5Core.dll'))
if File.exists?(File.join(release_dll_path, 'Qt6Core.dll'))
qt_dll_path = release_dll_path
elsif File.exist?(File.join(debug_dll_path, 'Qt5Core.dll'))
elsif File.exists?(File.join(debug_dll_path, 'Qt6Core.dll'))
qt_dll_path = debug_dll_path
end
end
Expand Down
6 changes: 3 additions & 3 deletions src/openstudio_app/AboutBox.hpp.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<p><a href='https://openstudio.net'>OpenStudio SDK (core)</a> version: ${openstudio_VERSION}</p> \
<p>Copyright &copy; 2020-2023, OpenStudio Coalition and other contributors. All rights reserved.</p> \
<p>OpenStudio is a cross-platform tool to support whole building energy and daylight modeling using <a href='http://apps1.eere.energy.gov/buildings/energyplus/'>EnergyPlus</a> and <a href='http://www.radiance-online.org/'>Radiance</a>.</p> \
<p>OpenStudio uses the following QT modules (version 6.3.0) that are dynamically linked using GNU Lesser General Public License (LGPL): \
<font size='2'> Qt5Core, Qt5Widgets, Qt5Sql, Qt5Network, Qt5Xml, Qt5Concurrent, Qt5PrintSupport, Qt5Gui,Qt5Quick, Qt5QuickWidgets, Qt5Qml, Qt5WebChannel, Qt5Positioning, Qt5WebEngine, Qt5WebEngineWidgets, QtWebEngineCore, Qt5DBus, Qt5WinExtras</font> </p> \
<p> For information on QT, please refer to <a href='https://doc.qt.io/qt-6.2/qtmodules.html'>QT</a></p> \
<p>OpenStudio uses the following QT modules (version ${QT_VERSION}) that are dynamically linked using GNU Lesser General Public License (LGPL): \
<font size='2'>Qt6Core, Qt6Core5Compat Qt6Widgets, Qt6Network, Qt6Concurrent, Qt6PrintSupport, Qt6Gui, Qt6Quick, Qt6QuickWidgets, Qt6Qml, Qt6QmlModels, Qt6WebChannel, Qt6Positioning, Qt6WebEngine, Qt6WebEngineWidgets, QtWebEngineCore, Qt6DBus, Qt6Xml, Qt6Svg, Qt6OpenGL</font> </p> \
<p> For information on QT, please refer to <a href='${QT_DOC_LINK}'>QT</a></p> \
<p> A copy of the GPL 3.0 and LGPL 3.0 are included in the root path of your installation directory.</p>"
#endif // OPENSTUDIOAPP_ABOUTBOX
Loading