-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Clang on Windows #470
base: develop
Are you sure you want to change the base?
Conversation
Is this ready for review? Looks like the clang MSVC runner failed. There are conflicts too apparently. |
No I didn't get this working yet, looks like I can't convert to draft PR because of the conflict |
cmake --build . -j 2 --config ${{ env.BUILD_TYPE }} | ||
cmake --build . --target package -j 2 --config ${{ env.BUILD_TYPE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I haven't found a way to get that working either... When using ninja it's nearly impossible to pass a toolset without using a toolset file...
ConanInstall.cmake
Outdated
if(WIN32) | ||
# Use MSVC for dependencies on Windows | ||
set(CMAKE_CXX_COMPILER_ID_TMP "${CMAKE_CXX_COMPILER_ID}") | ||
set(CMAKE_CXX_COMPILER_ID "MSVC") | ||
set(CMAKE_GENERATOR_TOOLSET_TMP "CMAKE_GENERATOR_TOOLSET") | ||
set(CMAKE_GENERATOR_TOOLSET "") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, that makes me scared a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use ClangCL deps?
maybe need a |
@macumber FYI I had to force push and it was refusing to merge properly (shorthand MERGE_HEAD not found or whatever) |
No description provided.