Replace var in javascript with let/const #5558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Not in unmerged pull requests. |
HolgerJeromin
approved these changes
Jan 27, 2025
Closed
tomhughes
force-pushed
the
var-let-const
branch
2 times, most recently
from
728d991 to
4e28e7f
Compare
hlfan
approved these changes
Jan 30, 2025
|
If this is merged, I'll have to rewrite #5064 again. That's a bugfix PR. People are still complaining about bugs it fixes. |
|
@AntonKhorev I'd still say merge sooner rather than later just because all the arising issues can be autofixed. |
tomhughes
force-pushed
the
var-let-const
branch
from
4e28e7f to
f3e092f
Compare
HolgerJeromin
approved these changes
Feb 2, 2025
tomhughes
force-pushed
the
var-let-const
branch
5 times, most recently
from
99fb2a9 to
f6416cd
Compare
tomhughes
force-pushed
the
var-let-const
branch
from
f6416cd to
0d31f55
Compare
hlfan
reviewed
Feb 9, 2025
Comment on lines
-45
to
+43
| url: content_path, | ||
| url: path, |
There was a problem hiding this comment.
If you're already cleaning up after me, you can define the function as function (url, callback) for even more conciseness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the eslint config to prohibit use of
varand to preferconstoverletand then fixes all uses ofvarto respect that.