Use map tiles dark mode from leaflet-osm plugin #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may have gotten a bit overexcited by #5421. |
tomhughes
requested changes
Dec 22, 2024
|
Since the line with the not (yet) supported optional chaining is only to make the updates work without the UI panes (like in the tests) anyway, the complexity of that predicate can be reduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version between #5396 and #5397 using the updated version of leaflet-osm without requiring it.
Also removing some ifs that always evaluate true and removed the dependency on the
.key-ui.