Put api keys directly in js layer definitions #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sure this could be improved, but a massive multi line block of ruby embedded is a js file is definitely not the answer to my mind at least. |
AntonKhorev
force-pushed
the
map-layer-configuration-api-keys
branch
from
25279c4 to
37ce56f
Compare
|
I moved that ruby code to a module, but now there's no dependency on it. If it's changed, |
AntonKhorev
force-pushed
the
map-layer-configuration-api-keys
branch
2 times, most recently
from
32d95eb to
7571bdf
Compare
Also don't generate definitions for layers that have require missing api keys.
AntonKhorev
force-pushed
the
map-layer-configuration-api-keys
branch
from
7571bdf to
2588e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently map layer API keys have one extra level of indirection:
osm.js.erbreads them from the settings and writes them toOSM.THUNDERFOREST_KEYandOSM.TRACESTRACK_KEYlayers.ymlcontain names ofOSMproperties to check for keysInstead of this
osm.js.erbcould write keys directly to layer definitions, skippingOSM.THUNDERFOREST_KEYandOSM.TRACESTRACK_KEY.layers.ymlcould contain the corresponding settings names. The advantage is that Thunderforest and Tracestrack keys are no longer special. A new key can be added just by editingsettings.ymlandlayers.yml. Also it's possible to skip layer definitions if they require a key and that key is missing.