Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shop=gold_buyer #1374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Nov 2, 2024

Description, Motivation & Context

part of #362 (sync NSI tags), but makes sense in general as this is a distinct POI type that ideally would be supported

Related issues

fixes #974

Links and data

see https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgold_buyer

Relevant tag usage stats:

low, but it appears to be a real POI type with no better marking

about 400 uses, increase from about 200 when #974 was created

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

github-actions bot commented Nov 2, 2024

🍱 You can preview the tagging presets of this pull request here.

@matkoniecz
Copy link
Contributor Author

for icon, I considered also temaki-money_hand

Test-Documentation

Preview links & Sidebar Screenshots

http://www.openstreetmap.org/node/2216692628
screen03

Search

screen06
screen07

area search ads also unwanted building=yes but it seems to be already affecting shops in general

Info-i

it does NOT work, no idea why yet, I tried using https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i but it seems to contain no info

screen05

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Nov 2, 2024

for info-i - see also #1375

I managed to target correct repository but linked content is not there

@tordans Do you know where is this i-button documentation? And why it fails to work despite content on OSM Wiki existing?

(maybe for some reason iD tries to use this broken data items? In such case I would leave fixing it for data item enthusiasts)

@tordans
Copy link
Collaborator

tordans commented Nov 3, 2024

@tordans Do you know where is this i-button documentation? And why it fails to work despite content on OSM Wiki existing?

Yeah, that is still hidden in https://github.com/openstreetmap/id-tagging-schema/pull/1257/files … hope to get this resolved soon.

(maybe for some reason iD tries to use this broken data items? In such case I would leave fixing it for data item enthusiasts)

It looks like the wikidata item is missing https://wiki.openstreetmap.org/w/index.php?search=gold_buyer&title=Special%3ASearch&profile=advanced&fulltext=1&ns120=1

I created it using https://wiki.openstreetmap.org/wiki/Special:NewItem as https://wiki.openstreetmap.org/wiki/Item:Q22659

We can add more details there…


Right now, it is not being picket up, yet https://pr-1374--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n2216692628&locale=en&map=20.00/47.56207/-52.74532

Lets wait for a few hours and try again…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider supporting shop=gold_buyer
2 participants