-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shop=gold_buyer #1374
base: main
Are you sure you want to change the base?
add shop=gold_buyer #1374
Conversation
a963851
to
39ed660
Compare
39ed660
to
7017ddf
Compare
🍱 You can preview the tagging presets of this pull request here. |
for icon, I considered also Test-DocumentationPreview links & Sidebar Screenshotshttp://www.openstreetmap.org/node/2216692628 Searcharea search ads also unwanted Info-
|
for info-i - see also #1375 I managed to target correct repository but linked content is not there @tordans Do you know where is this i-button documentation? And why it fails to work despite content on OSM Wiki existing? (maybe for some reason iD tries to use this broken data items? In such case I would leave fixing it for data item enthusiasts) |
Yeah, that is still hidden in https://github.com/openstreetmap/id-tagging-schema/pull/1257/files … hope to get this resolved soon.
It looks like the wikidata item is missing https://wiki.openstreetmap.org/w/index.php?search=gold_buyer&title=Special%3ASearch&profile=advanced&fulltext=1&ns120=1 I created it using https://wiki.openstreetmap.org/wiki/Special:NewItem as https://wiki.openstreetmap.org/wiki/Item:Q22659 We can add more details there… Right now, it is not being picket up, yet https://pr-1374--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n2216692628&locale=en&map=20.00/47.56207/-52.74532 Lets wait for a few hours and try again… |
Description, Motivation & Context
part of #362 (sync NSI tags), but makes sense in general as this is a distinct POI type that ideally would be supported
Related issues
fixes #974
Links and data
see https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgold_buyer
Relevant tag usage stats:
low, but it appears to be a real POI type with no better marking
about 400 uses, increase from about 200 when #974 was created
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.