Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate room=class; use room=classroom instead #1355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

winstonsung
Copy link

@winstonsung winstonsung commented Oct 9, 2024

Bug: #1355
Change-Id: I90545a86f84877fea5908fd097334b87b98682e7

Description, Motivation & Context

"classroom" is now a conpound word and being used more frequently than the old 2-word "class room" in English language.

The page "Tag:room=classroom" was created first.

The page "Tag:room=class" was never created as a non-redirect page.

Note also that documentation of tagging on the OpenStreetMap Wiki is not the final arbiter of 'correct' tagging.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Bug: openstreetmap#1355
Change-Id: I90545a86f84877fea5908fd097334b87b98682e7
Copy link

github-actions bot commented Oct 9, 2024

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Oct 10, 2024

@winstonsung I am not sure a deprecation is the right approach here to remove the tag. This came up before, so I wrote about it here https://github.com/openstreetmap/id-tagging-schema/pull/1357/files#diff-22e674f3d1da91695fbafd4d2c81f91246cfabab3d16dcf6492e6024797b4da5

We can wait for input by others to see if they would thinks this a good fit for the deprecation rules. However I suggest you look into the other methods mentioned in the linked section.

@tordans tordans added deprecating waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels Oct 10, 2024
@winstonsung
Copy link
Author

winstonsung commented Oct 10, 2024

I am not sure a deprecation is the right approach here to remove the tag.

  • I know the deprecated.json would only show up on iD when editing the element with the tag, and that's what I intended to do.
  • I've already done the clean-up by using JOSM.

@winstonsung
Copy link
Author

@Kovoschiz
Copy link

Kovoschiz commented Oct 10, 2024

Warning to others: You are not allowed to make undiscussed mass retagging internationally without following such rules https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct

No less importantly, don't "wiki-fiddle"
Both of your argument are false

  1. Creation of documentation doesn't approve or disapprove of a tag
  2. Your Taghistory URL is bugged. =class is still more numerous, and growing faster.

=class was supported by at least 1 application https://wiki.openstreetmap.org/wiki/OpenIndoor#Rooms

@winstonsung
Copy link
Author

So we should do it in the opposite way?

@Kovoschiz
Copy link

No, you shouldn't do anything until you have asked and reached a consensus, besides following all the regulations. At least I'm indecisive on this.

@winstonsung
Copy link
Author

  1. Your Taghistory URL is bugged. =class is still more numerous, and growing faster.

Is there any known issue that caused the bugged diagram?

@mxdanger
Copy link

Thank you for this change! Even if this pull is not merged it's good that we at least have a tagging discrepancy resolved. I'm an avid indoor mapper so it's good to see this going somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecating waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants