Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address field to amenity=parcel_locker #1338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gy-mate
Copy link
Contributor

@gy-mate gy-mate commented Sep 7, 2024

Description, Motivation & Context

amenity=parcel_lockers often have an address associated with them. This is usually available on the operator's website.

Related issues

None.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations
Screenshot 2024-09-07 at 13 16 12

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

github-actions bot commented Sep 7, 2024

🍱 You can preview the tagging presets of this pull request here.

@gy-mate
Copy link
Contributor Author

gy-mate commented Sep 7, 2024

@matkoniecz
Copy link
Contributor

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations

note that many are incorrectly added

amenity=parcel_lockers often have an address associated with them. This is usually available on the operator's website.

nope

at least in Poland they state closest address, which is not address of the parcel locker

@matkoniecz
Copy link
Contributor

I would be against further encouraging such bad tagging, unless it is actually correct tagging more often than not

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 1, 2024

at least in Poland they state closest address, which is not address of the parcel locker

@matkoniecz This may be the case in Poland but not in Germany (https://www.dhl.de/de/privatkunden/dhl-standorte-finden.html), Czechia (https://www.rohlik.cz/tema/rohlikpoint), Slovakia (https://www.alza.sk/alzabox#kde-najdes-svoj-alzabox) or Hungary (https://wiki.openstreetmap.org/wiki/Hungary/Jelölési_példák#Csomagautomata). The amenity=parcel_locker wiki page also says that "Parcel lockers may have an official address".

@ITineris said the following about this on the OSM Hungary Matrix server, which I agree with:

If this is the case in Poland, do not use it there (if the two are different). But where it is, why not use it to help navigation?

@vasony also agrees with these.

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 1, 2024

@vasony also mentioned that "the branch=* is the actual branch which does not contain the full address. E.g. 'Bp. 11. ker. Mathias Corvinus Collegium', meanwhile the address is '1113 Budapest, Tas vezér utca 3-7. ' Both information are listed on the website [of the parcel locker operator]."

So these might be two different information. I think that iD could help users wanting to add the address by showing an Address moreField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants