Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator field to highway=street_lamp #1327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CorruptComputer
Copy link
Contributor

@CorruptComputer CorruptComputer commented Aug 28, 2024

Description, Motivation & Context

I opened a PR to add operator presets to the NSI for highway=street_lamp: osmlab/name-suggestion-index#9851

This PR is to add the operator section to these objects so users can more easily add this data or even know its an available field.

Related issues

Closes openstreetmap/iD#10443

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Copy link

🍱 You can preview the tagging presets of this pull request here.

@CorruptComputer
Copy link
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

image

Search

image

Info-i

image

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@CorruptComputer
Copy link
Contributor Author

With the NSI addition released now, here is an updated screenshot of this with an operator included:
image

Compared to what 2.30.4 shows for these currently:
image

@CorruptComputer
Copy link
Contributor Author

Hey @tyrasd sorry for the ping, this PR has been waiting for review for a couple months and just wanted to check the status of it. If this isn't something you'd want to add just let me know and I can close this so its not just sitting here.

@CorruptComputer
Copy link
Contributor Author

CorruptComputer commented Nov 2, 2024

Hey @tordans, thank you for the mention in the other PR, I think I understand the hesitancy to add this.

When I was checking around for operators to add to the NSI I was using this Overpass query, it seems to work for fairly large areas:

[out:json][timeout:100];
(node["highway"="street_lamp"]({{bbox}}););
out center;

{{style:
node
{ color:red; fill-color:red; }

node[operator]
{ color:yellow; fill-color:yellow; }

node[operator:wikidata]
{ color:green; fill-color:green; }
}}

The countries of Spain and Portugal for example:
image

I took a look at the QLever links you had mentioned, I've never used SPARQL before but reading through those I think I have a rough idea of how it works. I'll see if I can get something made to check for this, but in the mean time that Overpass query could help if you wanted to just manually check around for usages of this.

Edit:
Not sure if this was what you were looking for, but I was able to come up with this for the state query:
https://qlever.cs.uni-freiburg.de/osm-planet/NZwy85

The country query kept throwing errors that the server was out of RAM, so I'm not sure if I can test any changes to that one.

Tried to allocate 16.3 GB, but only 13.1 GB were available. Clear the cache or allow more memory for QLever during startup

@tordans
Copy link
Collaborator

tordans commented Nov 3, 2024

Thanks for the query @CorruptComputer
I asked at https://osmus.slack.com/archives/C1R62SM9T/p1730613008738959 if someone knows how to get the country query going.
And also maybe taginfo/taginfo#440 will give an answer to this problem at some point.

Another way to get some stats is https://dashboard.ohsome.org/#backend=ohsomeApi&groupBy=boundary&time=%2F2024-10-14T13%3A00Z%2FP1M&measure=count&filter=highway%3Dstreet_lamp+and+operator%3D*&adminids=-148838%2C-1428125%2C-295480%2C-1311341%2C-51477%2C-62149%2C-62273%2C-52411%2C-2323309%2C-50046%2C-2978650%2C-52822%2C-49715%2C-16239%2C-51684%2C-214885%2C-218657%2C-2202162%2C-51701%2C-365331

image

(I selected a few countries but not by any system, so there are likely gaps in here)

- - date number
148838 United__States 2024-10-14 11352
1428125 Canada 2024-10-14 45850
295480 Portugal 2024-10-14 69
1311341 Spain 2024-10-14 712
51477 Germany 2024-10-14 53757
62149 United__Kingdom 2024-10-14 5879
62273 Ireland 2024-10-14 196
52411 Belgium 2024-10-14 177
2323309 Netherlands 2024-10-14 1118
50046 Denmark 2024-10-14 65
2978650 Norway 2024-10-14 87
52822 Sweden 2024-10-14 627
49715 Poland 2024-10-14 1451
16239 Austria 2024-10-14 8
51684 Czechia 2024-10-14 25
214885 Croatia 2024-10-14 95
218657 Slovenia 2024-10-14 11
2202162 France 2024-10-14 47438
51701 Switzerland 2024-10-14 473
365331 Italy 2024-10-14 6418

@CorruptComputer
Copy link
Contributor Author

Its not a great solution, but after some tinkering I found that you can query this by boundary=timezone: https://qlever.cs.uni-freiburg.de/osm-planet/9g0Ztr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an operator field when selecting "highway=street_lamp" objects
2 participants