Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for entrance=shop #1299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deevroman
Copy link
Contributor

@deevroman deevroman commented Jul 26, 2024

@deevroman deevroman marked this pull request as ready for review July 26, 2024 12:38
Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Collaborator

@Zverik Zverik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tag used 33k times

@Zverik Zverik requested a review from tyrasd July 26, 2024 13:04
@kjonosm
Copy link
Contributor

kjonosm commented Jul 26, 2024

image

@tordans
Copy link
Collaborator

tordans commented Jul 29, 2024

What are the search terms you would use to add this preset?
I wonder if we are on the right track by adding separate presets for all of those entrance values.
(There are a few already…)

My usage scenario is, to search for "entrance" in iD – but never more concrete like "main entrance". I then select the general entrance and specify the type if appropriate.

Give this usage, it would be better to make all the specific presets unsearchable and add search terms to the general entrance preset. (Something similar was talked about for crossings in #1044.)

Does this make sense? And would you be up to expand this PR to include this refactoring?


An argument for this preset is, that there is a dedicated Wiki page https://wiki.openstreetmap.org/wiki/Tag%3Aentrance%3Dshop and Wikidata Item. However, usage is quite lower (for now) than the other values:

image

Source

@Dimitar5555
Copy link
Contributor

My usage scenario is, to search for "entrance" in iD – but never more concrete like "main entrance". I then select the general entrance and specify the type if appropriate.

Give this usage, it would be better to make all the specific presets unsearchable and add search terms to the general entrance preset. (Something similar was talked about for crossings in #1044.)

Does this make sense? And would you be up to expand this PR to include this refactoring?

The point of having them as searchable presets is to reduce the amount of clicks needed to apply them. Try to add the entrances of a dozen long panel buildings using your method and then using the specific preset.

@deevroman
Copy link
Contributor Author

deevroman commented Jul 29, 2024

What are the search terms you would use to add this preset?

shop :) Note that the preset only works for vertex

I wonder if we are on the right track by adding separate presets for all of those entrance values.

I don't think that's the problem. The most common tag entrance=yes is now in the first place

The only problem that bothers me when adding more presets for inputs is the same icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants