-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset for entrance=shop #1299
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tag used 33k times
What are the search terms you would use to add this preset? My usage scenario is, to search for "entrance" in iD – but never more concrete like "main entrance". I then select the general entrance and specify the type if appropriate. Give this usage, it would be better to make all the specific presets unsearchable and add search terms to the general entrance preset. (Something similar was talked about for crossings in #1044.) Does this make sense? And would you be up to expand this PR to include this refactoring? An argument for this preset is, that there is a dedicated Wiki page https://wiki.openstreetmap.org/wiki/Tag%3Aentrance%3Dshop and Wikidata Item. However, usage is quite lower (for now) than the other values: |
The point of having them as searchable presets is to reduce the amount of clicks needed to apply them. Try to add the entrances of a dozen long panel buildings using your method and then using the specific preset. |
https://wiki.openstreetmap.org/wiki/Tag%3Aentrance%3Dshop