fixed the overflowing combobox #10494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Hi, thanks for the effort. However, this fix is just moving the problem to a different situation: Now, the combobox will be cut off when the content would have to be displayed above the scroll:
A proper fix would need to dynamically choose to display the dropdown above the input element only if the content would not fit on the remaining space on the page . See tooltip.js for a module which already implements this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #10482
the current comboBox box css styles makes the content overflow out of the screen which creates a bad user experience .
Solved this by tweaking the marginTop of the comboBox
Previous
Modified