Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: set redirecturl to null when unparseable #142

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Badmuts
Copy link
Contributor

@Badmuts Badmuts commented Dec 7, 2023

When given redirect url is unparseable e.g. //openstad.org the redirectURL wasn't reset so the given redirectURL became allowed. This resets the redirecturl when parsing fails

Copy link
Collaborator

@nlsvgtr nlsvgtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@Badmuts Badmuts merged commit 672508c into master Dec 7, 2023
1 check passed
@Badmuts Badmuts deleted the hotfix/invalid-redirect-url branch December 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants