Fix/user update fails #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudivanhierden
requested changes
Oct 31, 2024
Comment on lines
-48
to
-92
| /** | ||
| * In case of setting the role | ||
| * Admin are allowed to set all roles, but moderators only are allowed | ||
| * to set members. | ||
| * | ||
| * @param actionUserRole | ||
| * @param action (c) | ||
| * @param user () | ||
| * @param self (user model) | ||
| * @param project (project on which model is queried) | ||
| */ | ||
| authorizeData: function(actionUserRole, action, user, self, project) { | ||
| if (!self) return; | ||
|
|
||
| const updateAllRoles = ['admin']; | ||
| const updateMemberRoles = ['moderator']; | ||
| const fallBackRole = 'anonymous'; | ||
| const memberRole = 'member'; | ||
|
|
||
| // this is the role for User on which action is performed, not of the user doing the update | ||
| actionUserRole = actionUserRole || self.role; | ||
|
|
||
| // by default return anonymous role if none of the conditions are met | ||
| let roleToReturn; | ||
|
|
||
| // only for create and update check if allowed, the other option, view and list | ||
| // for now its ok if a the public sees the role | ||
| // for fields no DELETE action exists | ||
| if (action === 'create' || action === 'update') { | ||
| // if user is allowed to update all status | ||
| if (userHasRole(user, updateAllRoles)) { | ||
| roleToReturn = actionUserRole; | ||
| // check if active user is allowed to set user's role to member | ||
| } else if (userHasRole(user, updateMemberRoles) && actionUserRole === memberRole) { | ||
| roleToReturn = actionUserRole; | ||
| } else { | ||
| roleToReturn = fallBackRole; | ||
| } | ||
|
|
||
| } else { | ||
| roleToReturn = actionUserRole; | ||
| } | ||
|
|
||
| return roleToReturn; | ||
| }, |
There was a problem hiding this comment.
Moet dit er niet in blijven? Lijkt me op zich wel een goede functionaliteit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deze PR lost de volgende punten op
En wellicht deze: