Feature/allow backup cronjobs to be run by a k8s cronjob ams #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rudi van Hierden <[email protected]>
Co-authored-by: Rudi van Hierden <[email protected]>
Co-authored-by: Rudi van Hierden <[email protected]>
…-api into feature/gitops-workflow
This allows the react-admin to list and view the submissions, and generate a CSV export. Related ticket: https://trello.com/c/MHQ88xsW/81-inzendingen-resource-form-submission-beschikbaar-maken-voor-export
Also changes some `var` to `const` at the top-level requires and remove some unnecessary & commented code.
…-and-viewable-rebase Feature/make submissions listable and viewable rebase
Feature/submission events draad
add github workflows with gitops flow
This allows us to create a cronjob in Kubernetes which runs just this file, while also allowing us to skip the built-in backup cronjobs with the PREVENT_BACKUP_CRONJOBS environment variable set to `true`. This commit also prevents the normal mysql & mongodb backups to be run when the S3 variant is turned on.
…w-backup-cronjobs-to-be-run-by-a-k8s-cronjob
rudivanhierden
requested changes
Aug 2, 2023
There was a problem hiding this comment.
The changes in this file don't belong in this PR
Comment on lines
+29
to
+32
| ## UNRELEASED | ||
| * Change mongoDB S3 backup to read the database dump in chunks and upload it to the S3 bucket using a MultiPart upload setup. | ||
| * Allow s3 backups to be disabled from the cronjobs, but instead be run through a different entrypoint (backup.js) to allow kubernetes cronjobs to be used. | ||
|
|
There was a problem hiding this comment.
Can you push this to the top of the file?
|
See #312 for correct PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include
Issue reference
Fixes # (issue)
Type of change
Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that
Documentation
Is the documentation updated, maybe a link
Tests
(How) has the change been tested
Branch
If the branch to merge to is not development