Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tls cert secret validation due VerifyCertSecrets() change #326

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update tls cert secret validation due VerifyCertSecrets() change #326

merged 1 commit into from
Sep 6, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Sep 6, 2024 •
edited by openshift-ci bot
Loading

@openshift-ci openshift-ci bot added the approved label Sep 6, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/334d9299e1d54145b3e934744d8748bc

❌ openstack-k8s-operators-content-provider FAILURE in 13m 01s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi stuggi requested a review from abays September 6, 2024 10:20
@stuggi
Copy link
Contributor Author

stuggi commented Sep 6, 2024

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Sep 6, 2024

recheck

abays
abays approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor Author

stuggi commented Sep 6, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit b11384c into openstack-k8s-operators:main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@dprince dprince Awaiting requested review from dprince

@fmount fmount Awaiting requested review from fmount

Assignees

@abays abays

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuggi @abays