Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Octavia SSH adoption test #859

Conversation

weinimo
Copy link
Contributor

@weinimo weinimo commented Mar 17, 2025

Octavia SSH key adoption is an optional step and should not block verification. Currently this test does not work in downstream CI.

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 859,a72d5c49114510f901708d53695e046a46b6291b

@weinimo
Copy link
Contributor Author

weinimo commented Mar 18, 2025

/retest

@weinimo
Copy link
Contributor Author

weinimo commented Mar 18, 2025

@jistr @klgill could you please review this change ASAP? This is blocking the downstream CI testing.

@weinimo weinimo requested review from jistr and klgill March 18, 2025 12:28
Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weinimo FYI I only need to review docs that are in the docs_user folder, but this LGTM.

Copy link
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3e3f48a into openstack-k8s-operators:main Mar 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants