Make ospdo adoption namespace changes simpler #856
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -17,7 +17,7 @@ You must upgrade the Compute services from {rhos_prev_long} {rhos_prev_ver} to { | |||
| DEFAULT_CELL_NAME="cell1" | |||
| RENAMED_CELLS="$DEFAULT_CELL_NAME" | |||
| NAMESPACE="openstack" | |||
| oc project "rhoso" | |||
There was a problem hiding this comment.
You should reflect that on the tests roles code as well, there is some logic built around NAMESPACE env var, so those must match the docs
There was a problem hiding this comment.
I think "rhoso" project usage should be scoped to OSPDO variant?
There was a problem hiding this comment.
then in the director operator case , what will the customer know to use ?
"openstack" would be the default namespace for ospdo, then in rhoso the customer should explicitly know which NS to use no ?
There was a problem hiding this comment.
Yes but is the oc project "rhoso" scoped for OSPDO docs only? To me it looks like we're changing the default on non-OSPDO too here.
| @@ -31,7 +31,7 @@ done | |||
| + | |||
| ---- | |||
| $ for CELL in $(echo $RENAMED_CELLS); do | |||
| oc exec openstack-$CELL-galera-0 -n $NAMESPACE -c galera -- mysql -rs -uroot -p"${PODIFIED_DB_ROOT_PASSWORD[$CELL]}" \ | |||
| oc exec openstack-$CELL-galera-0 f-c galera -- mysql -rs -uroot -p"${PODIFIED_DB_ROOT_PASSWORD[$CELL]}" \ | |||
| In Director Operator adoption you must define which namespace is being used for resources manipulation. | ||
| Since with Director Operator the adopted namespace would be "openstack", the adopting namespace ,for rhoso , would be "rhoso". |
There was a problem hiding this comment.
| In Director Operator adoption you must define which namespace is being used for resources manipulation. | |
| Since with Director Operator the adopted namespace would be "openstack", the adopting namespace ,for rhoso , would be "rhoso". | |
| In director Operator adoption, you must define which namespace is being used for resources manipulation. | |
| For director Operator adoption, the adopted namespace is `openstack`. If you are adopting a RHOSO environment, the adopted namespace is `rhoso`. |
I'm not sure if we need the last sentence about RHOSO, since this procedure only applies to director Operator.
Jira: https://issues.redhat.com/browse/OSPRH-14644