[18.0-fr1] Backports batch 2 #712
Open
+174
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref OSPRH-11281 Signed-off-by: Fabricio Aguiar <[email protected]> (cherry picked from commit 6914dd7)
When both `prelaunch_test_instance` and `ping_test` are true, starts a ping during `development_environment` and stop it in `_stop_ping_test.yaml`. Depending on the threashold defined, it will ensure that we were able to ping the instance' FIP during the entire adoption process. Currently only activated for jobs that leverage `test_with_ceph.yaml`. When we got some ping failure but still are under the threshold we add a warning to the output, without failing. That might be useful to debug the problem later. We also convert the ping log with human readable date and time for easier debugging when the ping test fails or is in warning. Test is deactivated by default and ping loss should be 0. All those can be configured in the job. (cherry picked from commit 7b19bd0)
(cherry picked from commit 5c72957)
oc wait fails if the storage instances have not been created yet. This fix will retry to ensure it does not fail before instances are created. (cherry picked from commit b999b38)
klgill
approved these changes
Nov 8, 2024
ciecierski
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports for #665 #676 #699 #705 .