consolidated variables into adoption-attributes file #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tl;dr This is not ready for review.
After a lot of testing, I consolidated the variables needed upstream and downstream into the adoption-attributes file. I migrated any common variables from the rhoso-attributes file into the adoption-attributes file. Then I used ifevals within the adoption-attributes file to differentiate upstream-specific and downstream-specific variables.
I am setting this PR to draft because I'm waiting for feedback from my team about the method used above, i.e., is there any reason why I need to keep the rhoso_attributes file, as long as I make sure the common variables are up to date?