DNM Check binding dnsmasq listen-address to 0.0.0.0 #2454

danpawlik · 2024-10-14T14:40:14Z

There is an issue, that the DNS requests are redirected to the cloud provider to resolve domain: api-int.crc.testing. Normally it is right that it want to resolve, but the dnsmasq should take the query and reply, however this is not the case.
Let's set the dnsmasq listen-address to be accessible to all addresses on that host.

openshift-ci · 2024-10-14T14:40:38Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2024-10-14T14:40:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rlandy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arxcruz · 2024-10-14T16:31:55Z

/ok-to-test

softwarefactory-project-zuul · 2024-10-14T16:41:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/feb9d6a98c7245719a35903b68cb9285

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 44s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 11m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 09s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 04s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 15s
✔️ build-push-container-cifmw-client SUCCESS in 36m 37s
✔️ cifmw-molecule-ci_network SUCCESS in 4m 21s
✔️ cifmw-molecule-dnsmasq SUCCESS in 4m 34s
❌ cifmw-molecule-libvirt_manager FAILURE in 15m 10s
❌ cifmw-molecule-reproducer FAILURE in 11m 53s

There is an issue, that the DNS requests are redirected to the cloud provider to resolve domain: api-int.crc.testing. Normally it is right that it want to resolve, but the dnsmasq should take the query and reply, however this is not the case. Let's set the dnsmasq listen-address to be accessible to all addresses on that host.

softwarefactory-project-zuul · 2024-10-15T11:35:27Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f79008ea1cc64676997c6a96481acbc4

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 41s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 41m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 19s
✔️ build-push-container-cifmw-client SUCCESS in 37m 54s
✔️ cifmw-molecule-ci_network SUCCESS in 4m 21s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 30m 39s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 00s

danpawlik · 2024-10-15T12:05:36Z

recheck

lewisdenny · 2024-10-15T12:08:08Z

roles/libvirt_manager/tasks/create_networks.yml

@@ -197,7 +197,8 @@
    cifmw_dnsmasq_network_name: "{{ item.name }}"
    cifmw_dnsmasq_network_state: present
    cifmw_dnsmasq_network_definition: "{{ item }}"
-    cifmw_dnsmasq_network_listen_addresses: "{{ _dns_address[item.name] }}"
+    cifmw_dnsmasq_network_listen_addresses:


Please drop this file from this PR

lewisdenny · 2024-10-15T12:12:33Z

roles/ci_network/templates/local_domain.conf.j2

@@ -1,5 +1,5 @@
 # This file is generated by ci-framework tool
-listen-address={{ config.listen_addresses | join(',') }}
+listen-address=0.0.0.0


Please drop this file from this PR

lewisdenny · 2024-10-15T12:12:41Z

roles/ci_network/tasks/apply-dnsmasq.yml

@@ -60,8 +60,7 @@
  vars:
    data:
      listen_addresses:
-        - "127.0.0.1"
-        - "{{ ansible_default_ipv4.address }}"
+        - "0.0.0.0"


Please drop this file from this PR

lewisdenny · 2024-10-15T12:15:29Z

ci/playbooks/multinode-customizations.yml

            - name: Configure dnsmasq listen-address to listen on both br-ex and ci-private-network
              when:
                - not _dnsmasq.stat.exists
              become: true
              ansible.builtin.lineinfile:
                path: "{{ _dnsmasq_config }}"
-                insertafter: '^listen-address='
-                line: "listen-address={{ _crc_default_net_ip | ansible.utils.ipaddr('address') }}"
+                insertbefore: '^expand-hosts'


Is there a reason it needs to be before expand-hosts? if not, please just add it to EOF like line 95

Suggested change

insertbefore: '^expand-hosts'

insertafter: "EOF"

lewisdenny · 2024-10-15T12:16:13Z

ci/playbooks/multinode-customizations.yml

                validate: "{{ _validate }}"

+            - name: Print current config


Please remove this after your testing.

of course ;)

softwarefactory-project-zuul · 2024-10-15T14:43:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ae5b7ea489f14dd9ad2ac4f792c5c7d8

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 11s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 43m 55s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 20s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 09s
❌ build-push-container-cifmw-client FAILURE in 15m 55s
✔️ cifmw-molecule-ci_network SUCCESS in 4m 03s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 30m 11s
✔️ cifmw-molecule-reproducer SUCCESS in 13m 34s

lewisdenny · 2024-10-16T00:09:48Z

recheck
infra issues: Error: initializing source docker://quay.io/podified-antelope-centos9/openstack-iscsid:current-podified: pinging container registry quay.io: Get \\\"https://quay.io/v2/\\\": dial tcp: lookup quay.io:

softwarefactory-project-zuul · 2024-10-16T02:09:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2cdaca7fde544665ab344402da7ccd83

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 11s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 45m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 15s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 44s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 35s
❌ build-push-container-cifmw-client FAILURE in 7m 28s
✔️ cifmw-molecule-ci_network SUCCESS in 4m 49s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 40m 22s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 58s

danpawlik · 2024-10-16T08:03:58Z

Probably that change will require additional task that was proposed https://review.rdoproject.org/r/c/config/+/55035/4/roles/prepare-crc-extracted/tasks/dnsmasq-nm.yaml#80

which contains:

        - name: Set the bind interfaces
          become: true
          ansible.builtin.lineinfile:
            path: /etc/dnsmasq.d/crc-dnsmasq.conf
            line: "interface={{ item }}"
          loop: "{{ ansible_facts['interfaces'] }}"
          when: "{{ item.startswith('enp') }} or {{ item.startswith('eth') }}"

It is just a PoC.

github-actions · 2024-11-01T02:49:26Z

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

openshift-ci bot added the do-not-merge/work-in-progress label Oct 14, 2024

openshift-ci bot added the ok-to-test label Oct 14, 2024

danpawlik force-pushed the improve-dns-config branch 2 times, most recently from a4ec153 to 9a66deb Compare October 15, 2024 07:47

danpawlik force-pushed the improve-dns-config branch from 9a66deb to e816ecb Compare October 15, 2024 08:55

lewisdenny requested changes Oct 15, 2024

View reviewed changes

lewisdenny self-assigned this Oct 15, 2024

github-actions bot added the Stale label Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNM Check binding dnsmasq listen-address to 0.0.0.0 #2454

DNM Check binding dnsmasq listen-address to 0.0.0.0 #2454

danpawlik commented Oct 14, 2024

openshift-ci bot commented Oct 14, 2024

openshift-ci bot commented Oct 14, 2024

arxcruz commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 15, 2024

danpawlik commented Oct 15, 2024

lewisdenny Oct 15, 2024

lewisdenny Oct 15, 2024

lewisdenny Oct 15, 2024

lewisdenny Oct 15, 2024

lewisdenny Oct 15, 2024

danpawlik Oct 15, 2024

softwarefactory-project-zuul bot commented Oct 15, 2024

lewisdenny commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 16, 2024

danpawlik commented Oct 16, 2024

github-actions bot commented Nov 1, 2024

DNM Check binding dnsmasq listen-address to 0.0.0.0 #2454

Are you sure you want to change the base?

DNM Check binding dnsmasq listen-address to 0.0.0.0 #2454

Conversation

danpawlik commented Oct 14, 2024

openshift-ci bot commented Oct 14, 2024

openshift-ci bot commented Oct 14, 2024

arxcruz commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 15, 2024

danpawlik commented Oct 15, 2024

lewisdenny Oct 15, 2024

Choose a reason for hiding this comment

lewisdenny Oct 15, 2024

Choose a reason for hiding this comment

lewisdenny Oct 15, 2024

Choose a reason for hiding this comment

lewisdenny Oct 15, 2024

Choose a reason for hiding this comment

lewisdenny Oct 15, 2024

Choose a reason for hiding this comment

danpawlik Oct 15, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Oct 15, 2024

lewisdenny commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 16, 2024

danpawlik commented Oct 16, 2024

github-actions bot commented Nov 1, 2024