Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry decorator for download_image function #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Regis-Caelum
Copy link

Issues/PR

Fix Issue #775.

Changes

*************Module*************
zaza/openstack/utilities/openstack.py

Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your patch. There are however, a couple of problems.

One minor comment on the actual change; however, the multiple formatting changes obscure the change and should not be part of the PR please. Also, they cause a PEP8 failure as many of them are not compatible with the PEP8 options for the project. Please use tox -e pep8 and tox -e py3 to verify your changes prior to submission. Thanks.

Comment on lines +2306 to +2316
DNS_ISSUES = [
EAI_AGAIN,
EAI_BADFLAGS,
EAI_FAIL,
EAI_FAMILY,
EAI_MEMORY,
EAI_NODATA,
EAI_NONAME,
EAI_SERVICE,
EAI_SOCKTYPE
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use a tuple here, rather than a list, to make it immutable as it should not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib.error.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>
2 participants