Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'edit' icon for actionable button #3686

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

There's a request to use edit icon for in-progress actionable button

Screen Shot 2025-01-15 at 18 44 44

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.9%. Comparing base (058508b) to head (626aa95).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ore/quest/ui/shared/components/ActionableButton.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3686   +/-   ##
=======================================
  Coverage     38.9%   38.9%           
- Complexity    1163    1164    +1     
=======================================
  Files          284     284           
  Lines        15078   15078           
  Branches      2671    2669    -2     
=======================================
+ Hits          5867    5872    +5     
+ Misses        8365    8361    -4     
+ Partials       846     845    -1     
Flag Coverage Δ
engine 62.5% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 25.1% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ore/quest/ui/shared/components/ActionableButton.kt 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@pld pld merged commit 3818ab8 into main Jan 15, 2025
4 of 5 checks passed
@pld pld deleted the edit-icon-for-actionable-button branch January 15, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants