Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain periodic sync completion with CustomSyncWorker #3635

Closed
wants to merge 12 commits into from

Conversation

Lentumunai-Mark
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 39 lines in your changes missing coverage. Please review.

Project coverage is 27.5%. Comparing base (996914e) to head (2a082e2).

Files with missing lines Patch % Lines
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 0.0% 16 Missing ⚠️
...core/engine/configuration/ConfigurationRegistry.kt 44.4% 8 Missing and 7 partials ⚠️
...rtregister/fhircore/engine/sync/CustomSyncState.kt 0.0% 4 Missing ⚠️
...register/fhircore/engine/sync/CustomWorkerState.kt 0.0% 3 Missing ⚠️
...tregister/fhircore/engine/sync/CustomSyncWorker.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3635   +/-   ##
=======================================
  Coverage     27.4%   27.5%           
- Complexity     789     790    +1     
=======================================
  Files          282     284    +2     
  Lines        14695   14680   -15     
  Branches      2632    2616   -16     
=======================================
+ Hits          4040    4042    +2     
+ Misses       10100   10079   -21     
- Partials       555     559    +4     
Flag Coverage Δ
engine 63.3% <23.5%> (-0.4%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...core/quest/ui/geowidget/GeoWidgetLauncherScreen.kt 0.0% <ø> (ø)
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 3.3% <ø> (+<0.1%) ⬆️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 0.0% <ø> (ø)
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <ø> (ø)
...rcore/quest/ui/shared/components/SyncStatusView.kt 0.0% <ø> (ø)
...tregister/fhircore/engine/sync/CustomSyncWorker.kt 56.2% <0.0%> (-1.9%) ⬇️
...register/fhircore/engine/sync/CustomWorkerState.kt 0.0% <0.0%> (ø)
...rtregister/fhircore/engine/sync/CustomSyncState.kt 0.0% <0.0%> (ø)
...core/engine/configuration/ConfigurationRegistry.kt 66.4% <44.4%> (-2.0%) ⬇️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 16.3% <0.0%> (-4.8%) ⬇️

@Lentumunai-Mark Lentumunai-Mark marked this pull request as draft November 27, 2024 06:17
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review November 27, 2024 06:17
dubdabasoduba
dubdabasoduba previously approved these changes Nov 27, 2024
@ellykits ellykits changed the title feat(sync): chain periodic sync completion with CustomSyncWorker execution Chain periodic sync completion with CustomSyncWorker Nov 28, 2024
@ellykits
Copy link
Collaborator

@Lentumunai-Mark What happens when the custom sync is complete? Are you observing any states?

Lentumunai-Mark and others added 8 commits November 28, 2024 13:42
Signed-off-by: Lentumunai-Mark <[email protected]>
* Migrate FHIR SDK Artifacts to the latest version changes

* Reduce the verbosity of logs on CI 🧱

* Refactor FhirCarePlanGeneratorTest unit test for Future Proofing 💚

---------

Co-authored-by: Benjamin Mwalimu <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
…erformance (#3634)

* Start register data refactor

Signed-off-by: Elly Kitoto <[email protected]>

* Fix loading related resources data

Signed-off-by: Elly Kitoto <[email protected]>

* Optimize import

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor implementation for counting related resources

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor implementation for loading profile data

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor the rest of implementation using DefaultRepository

Signed-off-by: Elly Kitoto <[email protected]>

* Use coding system on REL filter query

Signed-off-by: Elly Kitoto <[email protected]>

* Fix count with REL filter applied

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor retrieval of REL tag locationIds

Signed-off-by: Elly Kitoto <[email protected]>

* Revert paging3 implementation

Signed-off-by: Elly Kitoto <[email protected]>

* Set pager prefetch size to half of page size

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotless

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor code

Signed-off-by: Elly Kitoto <[email protected]>

* Fix redundant count of related resources

Signed-off-by: Elly Kitoto <[email protected]>

* Refactor implementation

Signed-off-by: Elly Kitoto <[email protected]>

* Remove unnecessary coroutine context switching

Signed-off-by: Elly Kitoto <[email protected]>

* Fix failing engine tests

Signed-off-by: Elly Kitoto <[email protected]>

* Fix failing tests

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotlessApply

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotless

Signed-off-by: Elly Kitoto <[email protected]>

* Fix failing lint check

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotlessApply

Signed-off-by: Elly Kitoto <[email protected]>

* Fix failing lint check

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotlessApply

Signed-off-by: Elly Kitoto <[email protected]>

* Fix failing tests

Signed-off-by: Elly Kitoto <[email protected]>

* Run spotlessApply

Signed-off-by: Elly Kitoto <[email protected]>

* Format code

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
@Lentumunai-Mark
Copy link
Contributor Author

closing this in favor of #3650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants