Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading related resources data for LIST #3539

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Oct 4, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/ona-health/hisp-wdf-fhir-resources/issues/513

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ellykits ellykits self-assigned this Oct 4, 2024
@ellykits ellykits added the Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.1%. Comparing base (8cf03cf) to head (2e8ef96).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ircore/quest/ui/shared/components/ViewGenerator.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3539     +/-   ##
=========================================
- Coverage     27.2%   26.1%   -1.2%     
+ Complexity     756     711     -45     
=========================================
  Files          278     277      -1     
  Lines        14219   13650    -569     
  Branches      2581    2497     -84     
=========================================
- Hits          3880    3564    -316     
+ Misses        9801    9599    -202     
+ Partials       538     487     -51     
Flag Coverage Δ
geowidget 15.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ircore/engine/configuration/view/ListProperties.kt 90.0% <ø> (-1.7%) ⬇️
...re/engine/rulesengine/ResourceDataRulesExecutor.kt 89.4% <ø> (+4.5%) ⬆️
...gister/fhircore/engine/rulesengine/RulesFactory.kt 66.9% <ø> (-0.3%) ⬇️
...gister/fhircore/quest/ui/shared/components/List.kt 0.0% <ø> (ø)
...ircore/quest/ui/shared/components/ViewGenerator.kt 0.0% <0.0%> (ø)

... and 33 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant