Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected #3526

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark commented Sep 30, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3524

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (83bb186) to head (8299bef).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/geowidget/GeoWidgetLauncherViewModel.kt 0.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3526     +/-   ##
=========================================
- Coverage     27.2%   27.2%   -0.1%     
  Complexity     756     756             
=========================================
  Files          278     278             
  Lines        14219   14221      +2     
  Branches      2581    2581             
=========================================
  Hits          3880    3880             
- Misses        9801    9803      +2     
  Partials       538     538             
Flag Coverage Δ
engine 63.8% <ø> (ø)
geowidget 15.4% <ø> (ø)
quest 5.6% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/quest/ui/geowidget/GeoWidgetLauncherViewModel.kt 0.0% <0.0%> (ø)

@Lentumunai-Mark Lentumunai-Mark marked this pull request as draft September 30, 2024 13:16
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review October 1, 2024 07:50
@ellykits ellykits merged commit 3b66b02 into main Oct 7, 2024
4 of 5 checks passed
@ellykits ellykits deleted the Fix/map-no-results-dialogue branch October 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected.
2 participants