-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor register filter with REL tags #3488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
ellykits
added
the
Work In Progress
Describes an items that is not complete. Mostly used for scoping issues of discussions
label
Sep 11, 2024
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
…to fix-register-filters
…to fix-register-filters
dubdabasoduba
requested changes
Sep 12, 2024
.../main/java/org/smartregister/fhircore/engine/configuration/register/RegisterConfiguration.kt
Outdated
Show resolved
Hide resolved
...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt
Outdated
Show resolved
Hide resolved
This works well on the app, the performance is not great but it works Screenrecorder-2024-09-12-16-31-21-294.mp4 |
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
This fix ensures all the nested related resources are loaded too. Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
A lot of memory was used in heap during the allocation. Emojis are not used in the app so intializing them automatically is unnecessary. Signed-off-by: Elly Kitoto <[email protected]>
…to fix-register-filters
Signed-off-by: Elly Kitoto <[email protected]>
* Refactor load images tests for different views. Signed-off-by: Lentumunai-Mark <[email protected]> * Remove unutilized imports. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotlessApply Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> * Refactor load images tests for different views. Signed-off-by: Lentumunai-Mark <[email protected]> * Resolve conflicts. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
...oid/quest/src/main/java/org/smartregister/fhircore/quest/util/extensions/ConfigExtensions.kt
Outdated
Show resolved
Hide resolved
* Load map data in batches Signed-off-by: Elly Kitoto <[email protected]> * Update observer Signed-off-by: Elly Kitoto <[email protected]> * Deactivate infinite scroll by default Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
…#3456) * Fetch search results in batches for when loading all * Fix infinite loop for mocks with FhirEngine#search in tests * Add comparable FhirEngine#search vs batchedSearch integration tests
Signed-off-by: Elly Kitoto <[email protected]>
…to fix-register-filters
…to fix-register-filters
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
…to fix-register-filters
Signed-off-by: Elly Kitoto <[email protected]>
…to fix-register-filters
Signed-off-by: Elly Kitoto <[email protected]>
We need to reload all features when the search term is reset Signed-off-by: Elly Kitoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Work In Progress
Describes an items that is not complete. Mostly used for scoping issues of discussions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3473
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file