Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: Resolve docs errors on implementation guide #3285

Merged
merged 2 commits into from
May 23, 2024

Conversation

SebaMutuku
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.9%. Comparing base (ac82739) to head (8378e82).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3285      +/-   ##
==========================================
+ Coverage     29.6%   61.9%   +32.2%     
+ Complexity     658     620      -38     
==========================================
  Files          239     142      -97     
  Lines        11204    4980    -6224     
  Branches      1948     794    -1154     
==========================================
- Hits          3323    3083     -240     
+ Misses        7447    1498    -5949     
+ Partials       434     399      -35     
Flag Coverage Δ
engine 64.8% <ø> (-1.4%) ⬇️
geowidget 18.7% <ø> (-28.5%) ⬇️
quest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 116 files with indirect coverage changes

@SebaMutuku SebaMutuku enabled auto-merge (squash) May 22, 2024 11:53
@SebaMutuku SebaMutuku merged commit 2c7808f into main May 23, 2024
5 checks passed
@SebaMutuku SebaMutuku deleted the fix_docs_parsing_error branch May 23, 2024 19:23
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Resolve docs errors on implementation guide

* Fix JSON errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants