Fetch Practioner Location Id using Rules on the Configs from the SharedPreferences #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3281 +/- ##
=========================================
- Coverage 29.6% 28.0% -1.7%
- Complexity 658 690 +32
=========================================
Files 239 264 +25
Lines 11204 12396 +1192
Branches 1948 2164 +216
=========================================
+ Hits 3323 3477 +154
- Misses 7447 8460 +1013
- Partials 434 459 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ellykits
requested changes
May 23, 2024
Comment on lines
646
to
656
| ReflectionHelpers.callInstanceMethod<LoginViewModel>( | ||
| loginViewModel, | ||
| "writePractitionerDetailsToShredPref", | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf("")), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf("")), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf("")), | ||
| ReflectionHelpers.ClassParameter.from(PractitionerDetails::class.java, PractitionerDetails()), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf("")), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf("")), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf(locationId)), | ||
| ReflectionHelpers.ClassParameter.from(List::class.java, listOf(LocationHierarchy())), |
There was a problem hiding this comment.
You can just make the function public instead of using reflections here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3281 +/- ##
=========================================
- Coverage 29.6% 28.0% -1.7%
- Complexity 658 690 +32
=========================================
Files 239 264 +25
Lines 11204 12396 +1192
Branches 1948 2164 +216
=========================================
+ Hits 3323 3477 +154
- Misses 7447 8460 +1013
- Partials 434 459 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ellykits
approved these changes
May 24, 2024
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
…edPreferences (#3281) * Load practitioner location Id from the shared prefs via rules engine service * Add unit test for writing practitioner location id to shared preferences * Run spotlessApply * Update unit test * Run spotless Apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Part of the fixes for #2900
Adds the functionality for fetching the current practitioner's location Id.
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile