Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stack widget #3269

Merged
merged 17 commits into from
May 28, 2024
Merged

Implement Stack widget #3269

merged 17 commits into from
May 28, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark commented May 15, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3214

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 9.25926% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 27.9%. Comparing base (ac82739) to head (06460f8).
Report is 65 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3269     +/-   ##
=========================================
- Coverage     29.6%   27.9%   -1.7%     
- Complexity     658     690     +32     
=========================================
  Files          239     266     +27     
  Lines        11204   12452   +1248     
  Branches      1948    2167    +219     
=========================================
+ Hits          3323    3482    +159     
- Misses        7447    8511   +1064     
- Partials       434     459     +25     
Flag Coverage Δ
engine 64.6% <19.2%> (-1.6%) ⬇️
geowidget 18.7% <ø> (-28.5%) ⬇️
quest 5.2% <0.0%> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ircore/engine/configuration/view/ViewProperties.kt 86.3% <100.0%> (+3.0%) ⬆️
...tregister/fhircore/engine/domain/model/ViewType.kt 100.0% <100.0%> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (-1.2%) ⬇️
...ircore/quest/ui/shared/components/ViewGenerator.kt 0.0% <0.0%> (ø)
...e/engine/configuration/view/StackViewProperties.kt 0.0% <0.0%> (ø)
...r/fhircore/quest/ui/shared/components/StackView.kt 0.0% <0.0%> (ø)

... and 11 files with indirect coverage changes

@ellykits ellykits changed the title Stack widget to overlay photos and icons. Implement Stack widget May 16, 2024
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review May 21, 2024 07:52
Copy link
Collaborator

@ellykits ellykits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write documentation for the opensrp.io website. Update changelog.

@Lentumunai-Mark Lentumunai-Mark requested a review from ellykits May 27, 2024 08:26
@ellykits
Copy link
Collaborator

👍 LGTM.

@Lentumunai-Mark Lentumunai-Mark merged commit 7057c38 into main May 28, 2024
4 of 5 checks passed
@Lentumunai-Mark Lentumunai-Mark deleted the stack-widget branch May 28, 2024 13:56
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Implement a new stack widget.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add background color opacity.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Adjust box background to make it configurable.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add stack view test.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Interpolate child properties.

Signed-off-by: Lentumunai-Mark <[email protected]>

* Add stack widget documentation

* Update stack widget doc formatting

* Update ViewType.kt

---------

Signed-off-by: Lentumunai-Mark <[email protected]>
Co-authored-by: Benjamin Mwalimu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding overlays to photos and icons
3 participants