Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for hiding characters in a questions through an extension #3265

Merged
merged 4 commits into from
May 16, 2024

Conversation

SebaMutuku
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3264

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@SebaMutuku SebaMutuku changed the title Add Docs for Password hiding Add Docs for Password and other sensitive data hiding May 14, 2024
@SebaMutuku SebaMutuku changed the title Add Docs for Password and other sensitive data hiding Add docs for hiding characters in a questions through an extension May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.4%. Comparing base (ac82739) to head (318d949).
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3265     +/-   ##
=========================================
- Coverage     29.6%   29.4%   -0.2%     
- Complexity     658     693     +35     
=========================================
  Files          239     252     +13     
  Lines        11204   11911    +707     
  Branches      1948    2079    +131     
=========================================
+ Hits          3323    3512    +189     
- Misses        7447    7938    +491     
- Partials       434     461     +27     
Flag Coverage Δ
engine 64.8% <ø> (-1.4%) ⬇️
geowidget 47.2% <ø> (ø)
quest 5.5% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@pld pld merged commit d0833fb into main May 16, 2024
5 checks passed
@pld pld deleted the fix_issue_3264_add_docs_for_password_hiding branch May 16, 2024 02:44
qiarie pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for Hiding characters in a questionnaire
3 participants