3126 refactor config registry #3249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd processCompositionManifest
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
==========================================
+ Coverage 29.6% 47.2% +17.5%
+ Complexity 658 10 -648
==========================================
Files 239 4 -235
Lines 11204 235 -10969
Branches 1948 31 -1917
==========================================
- Hits 3323 111 -3212
+ Misses 7447 116 -7331
+ Partials 434 8 -426
Flags with carried forward coverage won't be shown. Click here to find out more. |
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/sync/SyncListenerManager.kt # android/engine/src/test/java/org/smartregister/fhircore/engine/sync/SyncBroadcasterTest.kt # android/engine/src/test/java/org/smartregister/fhircore/engine/sync/SyncListenerManagerTest.kt
| @@ -830,4 +898,276 @@ constructor( | |||
| ResourceType.Parameters, | |||
| ) | |||
| } | |||
|
|
|||
| private suspend fun fetchCompositionConfig(coroutineScope: CoroutineScope) { | |||
| val compConfigFlow1 = Sync.oneTimeSync<CompositionSyncWorker>(context) | |||
There was a problem hiding this comment.
Use full names for the variables e.g. compositionConfigFlow
| val compConfigFlow1 = Sync.oneTimeSync<CompositionSyncWorker>(context) | ||
| compConfigFlow1.handleCompositionSyncJobStatus(coroutineScope) | ||
| compConfigFlow1.collect { compConfigFlowJobStatus -> | ||
| when (compConfigFlowJobStatus) { |
There was a problem hiding this comment.
SAB(Same as above). compositionConfigFlowJobStatus
|
|
||
| resourceIds.forEach { | ||
| Timber.d("configSync composition Config adding resourceType - ${resourceType} and id= ${it}") | ||
| val compConfigParamPairsReq = mutableListOf<Pair<ResourceType, Map<String, String>>>() |
|
|
||
| private suspend fun fetchCompositionManifestRequest(coroutineScope: CoroutineScope) { | ||
|
|
||
| val compositionManifestFlow4 = Sync.oneTimeSync<CompositionManifestSyncWorker>(context) |
There was a problem hiding this comment.
we can remove the No. 4 suffix here since it is the only flow in this methods scope
| } | ||
|
|
||
| private suspend fun fetchCompositionListRequest(coroutineScope: CoroutineScope) { | ||
| val compListFlow2 = Sync.oneTimeSync<CompositionListSyncWorker>(context) |
| } | ||
|
|
||
| private suspend fun fetchCompositionConfigRequest(coroutineScope: CoroutineScope) { | ||
| val compositionConfigFlow3 = Sync.oneTimeSync<CompositionConfigSyncWorker>(context) |
|
|
||
|
|
||
| private suspend fun fetchCompListItemRequest(coroutineScope: CoroutineScope) { | ||
| val compListFlow2 = Sync.oneTimeSync<CompListItemSyncWorker>(context) |
added unit tests for worker classes
|
I am closing this PR. I will create a new one with fewer code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3126
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile