Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write doc about X-FHIR-Query as part of variable abilities #3112

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3111

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Feb 29, 2024
@FikriMilano FikriMilano enabled auto-merge (squash) February 29, 2024 09:50
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.6%. Comparing base (ac82739) to head (0eb833b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3112   +/-   ##
=======================================
  Coverage     29.6%   29.6%           
  Complexity     658     658           
=======================================
  Files          239     239           
  Lines        11204   11204           
  Branches      1948    1948           
=======================================
  Hits          3323    3323           
  Misses        7447    7447           
  Partials       434     434           
Flag Coverage Δ
engine 66.2% <ø> (ø)
geowidget 47.2% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ellykits
Copy link
Collaborator

@f-odhiambo Can you comment on this addition?

f-odhiambo
f-odhiambo previously approved these changes Mar 14, 2024
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pld pld force-pushed the 3111-doc-search-resource-using-variable branch from 37d4e6d to 0eb833b Compare March 18, 2024 16:43
@FikriMilano FikriMilano merged commit 7ec5117 into main Mar 18, 2024
5 checks passed
@FikriMilano FikriMilano deleted the 3111-doc-search-resource-using-variable branch March 18, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add X-FHIR-Query as part of variable abilities
4 participants