-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make app title visibility configurable in LoginScreen #3063
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3063 +/- ##
==========================================
- Coverage 64.5% 29.9% -34.6%
+ Complexity 1075 650 -425
==========================================
Files 218 236 +18
Lines 9635 10925 +1290
Branches 1897 1897
==========================================
- Hits 6218 3273 -2945
- Misses 2234 7231 +4997
+ Partials 1183 421 -762
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamza-vd can you please add a test to LoginScreen for this?
ef4e6b3
to
94d0c88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR will make app title visibility configurable in LoginScreen. This is something that was required for the mockup mentioned in this ticket
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file