Automatically clean up leaked openslide_t/openslide_cache_t refs
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gilbert <[email protected]>
Call openslide_close()/openslide_cache_release() from a Cleaner, ensuring we don't leak a handle if OpenSlide.close()/OpenSlideCache.close() is not called. Move the handle into a separate Wrapper class; we can't implement the cleanup Runnable directly on Ref because then the Cleaner would keep the Ref alive. The OpenSlide.close()/OpenSlideCache.close() methods are still the preferred way to release an object, since they're explicit and eager. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
openslide_close()/openslide_cache_release()from aCleaner, ensuring we don't leak a handle ifOpenSlide.close()/OpenSlideCache.close()is not called. Move the handle into a separateWrapperclass; we can't implement the cleanupRunnabledirectly onRefbecause then theCleanerwould keep theRefalive.The
OpenSlide.close()/OpenSlideCache.close()methods are still the preferred way to release an object, since they're explicit and eager.