Support OpenSlide cache management API #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Signed-off-by: Benjamin Gilbert <[email protected]>
Use the same semantics as the OpenSlide API. The OpenSlide class implements java.io.Closeable, which is documented to be for "a source or destination of data that can be closed". OpenSlideCache is technically a source or destination of data, but not at the Java API level, and the only reason it needs to be closeable is to release the underlying resource in the C API. Its superinterface java.lang.AutoCloseable is documented to be for "an object that may hold resources [...] until it is closed"; implement that instead. OpenSlide has a legacy dispose() method which is an alias for close(). Don't add a similar method to OpenSlideCache. Closes: openslide#36 Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same semantics as the OpenSlide API.
The
OpenSlideclass implementsjava.io.Closeable, which is documented to be fora source or destination of data that can be closed.OpenSlideCacheis technically a source or destination of data, but not at the Java API level, and the only reason it needs to be closeable is to release the underlying resource in the C API. Its superinterfacejava.lang.AutoCloseableis documented to be foran object that may hold resources [...] until it is closed; implement that instead.OpenSlide has a legacy
dispose()method which is an alias forclose(). Don't add a similar method toOpenSlideCache.Closes: #36