Skip to content

Commit

Permalink
workflows: remove source tarball as release artifact
Browse files Browse the repository at this point in the history
The source tarball is now identical to a git-archive of the Git tag, so
we can defer to the automatic "Source code" links in the GitHub release
instead of uploading a separate artifact.

Drop "Run test build" from the release checklist, since CI will do that
for us on each PR, including the one in the next step.

Signed-off-by: Benjamin Gilbert <[email protected]>
  • Loading branch information
bgilbert committed Apr 9, 2024
1 parent e6b4234 commit aa149f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/release.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# OpenSlide Java release process

- [ ] Run test build and `meson dist`
- [ ] Update `CHANGELOG.md` and version in `meson.build`
- [ ] Create and push signed tag
- [ ] Verify that GitHub Actions created a [GitHub release](https://github.com/openslide/openslide-java/releases) with release notes, a source tarball, and a JAR
- [ ] Verify that GitHub Actions created a [GitHub release](https://github.com/openslide/openslide-java/releases) with release notes and a JAR
- [ ] Update website: `_data/releases.yaml`, `_includes/news.md`
- [ ] Send mail to -announce and -users
- [ ] Post to [forum.image.sc](https://forum.image.sc/c/announcements/10)
7 changes: 3 additions & 4 deletions .github/workflows/java.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,9 @@ jobs:
if: matrix.dist
run: |
set -o pipefail
meson dist -C builddir
dist="openslide-java-dist-$GITHUB_RUN_NUMBER-$(echo $GITHUB_SHA | cut -c-10)"
echo "dist-base=$dist" >> $GITHUB_OUTPUT
mkdir -p "artifacts/$dist"
mv builddir/meson-dist/*.tar.xz "artifacts/$dist"
version=$(meson introspect --projectinfo builddir | jq -r .version)
mv builddir/openslide.jar \
"artifacts/${dist}/openslide-java-${version}.jar"
Expand All @@ -101,6 +99,8 @@ jobs:
permissions:
contents: write
steps:
- name: Check out repo
uses: actions/checkout@v4
- name: Download artifacts
uses: actions/download-artifact@v4
with:
Expand All @@ -111,11 +111,10 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
run: |
version=$(echo "${{ github.ref_name }}" | sed "s/^v//")
tar xf "${{ needs.build.outputs.dist-base }}/openslide-java-${version}.tar.xz"
awk -e '/^## / && ok {exit}' \
-e '/^## / {ok=1; next}' \
-e 'ok {print}' \
"openslide-java-${version}/CHANGELOG.md" > changes
CHANGELOG.md > changes
gh release create --prerelease --verify-tag \
--repo "${{ github.repository }}" \
--title "OpenSlide Java $version" \
Expand Down

0 comments on commit aa149f4

Please sign in to comment.