Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve rates as ints rather than doubles to make header parsing robust #1346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aymanhab
Copy link
Member

Fixes issue #1344

Brief summary of changes

Write frameRate, cameraRate etc. as ints to avoid confusing the parser built into MarkerData class (GUI doesn't have its own parser). Ideally we switch to the TimeSeriesTable to avoid duplicity but those need work to be usable by the GUI.

Testing I've completed

Tested workflow suggested in issue and it all worked.

CHANGELOG.md (choose one)

  • no need to update because...
  • updated...

@aymanhab aymanhab changed the title Prserve rates as ints rather than doubles to make header parsing robust Preserve rates as ints rather than doubles to make header parsing robust Apr 21, 2022
@nickbianco
Copy link
Member

Is it possible that any of these values can take non-integer values? Or do they get converted to ints when passed to the MarkerData class?

Otherwise, LGTM.

@aymanhab
Copy link
Member Author

@nickbianco In practice I've never seen rates that are non-ints, the MarkerData class uses doubles internally but reads/prints using custom simmIO class that's likely not robust and the long term plan should be to retire it altogether.

@nickbianco
Copy link
Member

Okay, sounds good. Seems like this a find stop-gap solution until replace the simmIO class later.

@aymanhab
Copy link
Member Author

Okay, sounds good. Seems like this a find stop-gap solution until replace the simmIO class later.

Agreed, will wait on more testing before merging. Thanks again @nickbianco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants