-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calibration #1513
Fix calibration #1513
Conversation
if your modifications were only designed to stop it happening at all, and not fixing if already happened, then no worries. |
How does it brick a device? I was aware about the issue but I haven't seen any way it can brick stuff |
This fix does nothing to correct wrong data, if you have NaN in there might be hard to get out, but recalibrating and reseting energy should I believe work |
I tested with bl602, it might have different NaN/division by zero handling. The issue was after I broke calibration, web page no longer loaded. |
🎉 This PR is included in version 1.18.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
You can set 0 or NAN as calibration constant currently, which should not be allowed, and in my case bricks the device.
Should be validated correctly.
Should fix #1502