Updated macro and variable decls to fit to POSIX and C89 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- macro __LINUX__ is replaced by __linux__ - removed variable declarations from for Signed-off-by: Sergey Oblomov <[email protected]>
|
You may want to check if the to: I'm happy to make this change, if you don't have access to a machine where you can try it out. |
|
@jdinan it would be great!!! thank you |
|
hmmm, I looked at Makefile.am - there is permanent definition of LINUX without any condition... it seems we may remove any checks for linux at all |
|
PR is not valid - here LINUX defines the scope of UNIX systems (technically not Windows) |
|
For what it's worth, I'm not aware of any OpenSHMEM implementation that supports Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39
Signed-off-by: Sergey Oblomov [email protected]