OCPBUGS-26986: Downstream sync - includes configurable schedule for reconciler #227
Conversation
Signed-off-by: nicklesimba <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
This change will allow us to unit test the configuration updates without having to create the CNI configuration files (they're unrelated to this unit). Signed-off-by: Miguel Duarte Barroso <[email protected]>
Move everything related to watching / updating the configuration to a separate pkg. That makes the code easier to follow, and allows us to properly unit test watching the configuration. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This allows us to use cron expressions with seconds in the tests, thus allowing the test run to finish a lot quicker. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
The lint target would fail otherwise, since the newly generated files != from the repo committed ones. Signed-off-by: Miguel Duarte Barroso <[email protected]>
|
/retest |
|
/approve |
|
/lgtm |
openshift-ci
bot
added
lgtm
liornoy
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, liornoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liornoy
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@liornoy: This pull request references Jira Issue OCPBUGS-26986, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@liornoy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@liornoy: Jira Issue OCPBUGS-26986: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26986 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-multus-whereabouts-ipam-cni-container-v4.16.0-202401111849.p0.gb24729e.assembly.stream for distgit ose-multus-whereabouts-ipam-cni. |
This PR syncs with upstream and cherry-picks all commits between:
37278e - Extended support for customizing whereabouts ip-reconciler cron schedule (22-11-22)
and
3f0dce - api: re-gen files to humor verify-codegen stages (08-01-23)
Important: we include here a bug fix (configurable schedule for reconciler) contained in this PR: k8snetworkplumbingwg/whereabouts#398