Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mce-install: Adjust 'OVERRIDE_HO_IMAGE' logic and display HO info #60167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LiangquanLi930
Copy link
Member

No description provided.

Copy link
Contributor

openshift-ci bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiangquanLi930

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2024
@openshift-ci openshift-ci bot requested review from csrwng and enxebre December 25, 2024 15:14
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LiangquanLi930: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-release-4.16-e2e-agent-disconnected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-ipv4-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-dualstack-metal3 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal3-compact-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-ipi-ovn-kubevirt-hypershift-mce-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal3-conformance N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal3-oadp N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-kubevirt-metal-ovn N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-mgmt-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-ovn-hypershift-mce-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-guest-f28-des N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-stable-4.14-aws-ipi-ovn-hypershift-mce-inplace-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-ipi-ovn-kubevirt-hypershift-mce-mgmt-f7 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.15-periodics-mce-e2e-power-ovn-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-baremetalds-agent-hypershift-mce-inplace-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-stable-4.15-baremetalds-agent-hypershift-mce-inplace-f60 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-kubevirt-aws-ovn-gpu N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-arm64-nightly-aws-ipi-ovn-hypershift-mce-mgmt-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-baremetalds-ipi-ovn-kubevirt-hypershift-mce-guest-f14-des N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-inplace-f60 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.16-aws-ipi-ovn-hypershift-mce-replace-f60 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-mgmt-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-ibmz-ovn-conformance N/A periodic Registry content changed

A total of 208 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal3-compact-conformance

@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Dec 25, 2024

@LiangquanLi930: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal3-compact-conformance 7b6f2a1 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal3-compact-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -233,10 +233,11 @@ metadata:
data:
hypershift-operator: ${OVERRIDE_HO_IMAGE}
EOF
while ! [ "$(oc get deployment operator -n hypershift -o jsonpath='{.status.conditions[?(@.type=="Progressing")].reason}')" == NewReplicaSetAvailable ]; do
while ! [ "$(oc get deployment operator -n hypershift -o jsonpath='{.spec.template.spec.containers[*].image}')" == "$OVERRIDE_HO_IMAGE" ]; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer [[ ]] instead of [] in the shell script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants