Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to odf-aws cluster profile inside red-hat-storage org #48750

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

malayparida2000
Copy link
Contributor

@malayparida2000 malayparida2000 commented Feb 13, 2024

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Feb 16, 2024

odf operator e2e was already flaky and had started to fail and was being overridden as seen in these PRs
4.11-red-hat-storage/odf-operator#319
4.12-red-hat-storage/odf-operator#318
4.13-red-hat-storage/odf-operator#353
4.14-red-hat-storage/odf-operator#354

So the failures to odf e2e tests on branches release-4.11 to release-4.14 can be safely ignored IMO, wdyt @iamniting ?

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Feb 16, 2024

Tests from mcg-ms-console & mcg-osd-deployer are failing due to unrelated reasons like in-consistent vendoring in the repo. These 2 repos have been dormant since last 1.5 years(since sep 2022), and these tests have not been recently run & they are failing due to unrelated reasons so these can be ignored in my opinion. wdyt @agarwal-mudit ?
https://github.com/red-hat-storage/mcg-ms-console
https://github.com/red-hat-storage/mcg-osd-deployer

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Feb 16, 2024

@SanjalKatiyar @bipuladh
This is a PR where we are switching to our own separate AWS cluster profile.
While making the changes we are rehearsing all the tests for all our repos. For odf-console the e2e-tests have passed for the other branches but for some reasons the test on the release-4.13 branch keeps failing with the error message

[2925:0216/154341.273481:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 3151: Permission denied (13)
[3151:0216/154341.288837:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/48750/rehearse-48750-pull-ci-red-hat-storage-odf-console-release-4.13-odf-console-e2e-aws/1758526699974168576

can you please take a look and share any insights? is it a genuine failure due to the new AWS profile
or can it be ignored?

@agarwal-mudit
Copy link
Contributor

Tests from mcg-ms-console & mcg-osd-deployer are failing due to unrelated reasons like in-consistent vendoring in the repo. These 2 repos have been dormant since last 1.5 years(since sep 2022), and these tests have not been recently run & they are failing due to unrelated reasons so these can be ignored in my opinion. wdyt @agarwal-mudit ? https://github.com/red-hat-storage/mcg-ms-console https://github.com/red-hat-storage/mcg-osd-deployer

Yes

@iamniting
Copy link
Member

odf operator e2e was already flaky and had started to fail and was being overridden as seen in these PRs 4.11-red-hat-storage/odf-operator#319 4.12-red-hat-storage/odf-operator#318 4.13-red-hat-storage/odf-operator#353 4.14-red-hat-storage/odf-operator#354

So the failures to odf e2e tests on branches release-4.11 to release-4.14 can be safely ignored IMO, wdyt @iamniting ?

Yes we can ignore odf failures.

@SanjalKatiyar
Copy link
Contributor

/pj-rehearse pull-ci-red-hat-storage-odf-console-release-4.13-odf-console-e2e-aws

@SanjalKatiyar
Copy link
Contributor

Tests from mcg-ms-console & mcg-osd-deployer are failing due to unrelated reasons like in-consistent vendoring in the repo. These 2 repos have been dormant since last 1.5 years(since sep 2022), and these tests have not been recently run & they are failing due to unrelated reasons so these can be ignored in my opinion. wdyt @agarwal-mudit ? https://github.com/red-hat-storage/mcg-ms-console https://github.com/red-hat-storage/mcg-osd-deployer

both these products are not supported anymore (in fact it was not even released), if needed we can remove their config from this repo too !!

@malayparida2000
Copy link
Contributor Author

Tests from mcg-ms-console & mcg-osd-deployer are failing due to unrelated reasons like in-consistent vendoring in the repo. These 2 repos have been dormant since last 1.5 years(since sep 2022), and these tests have not been recently run & they are failing due to unrelated reasons so these can be ignored in my opinion. wdyt @agarwal-mudit ? https://github.com/red-hat-storage/mcg-ms-console https://github.com/red-hat-storage/mcg-osd-deployer

both these products are not supported anymore (in fact it was not even released), if needed we can remove their config from this repo too !!

I can remove them in a follow up PR

@SanjalKatiyar
Copy link
Contributor

[2925:0216/154341.273481:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 3151: Permission denied (13)
[3151:0216/154341.288837:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

can you please take a look and share any insights? is it a genuine failure due to the new AWS profile or can it be ignored?

Let's re-run and check once more, we used to face this earlier due to low resources (cpu/memory), but current 1000m & 8Gi should be sufficient.

@malayparida2000
Copy link
Contributor Author

[2925:0216/154341.273481:ERROR:zygote_host_impl_linux.cc(263)] Failed to adjust OOM score of renderer with pid 3151: Permission denied (13)
[3151:0216/154341.288837:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

can you please take a look and share any insights? is it a genuine failure due to the new AWS profile or can it be ignored?

Let's re-run and check once more, we used to face this earlier due to low resources (cpu/memory), but current 1000m & 8Gi should be sufficient.

Failed again for the same reason. Does the 4.13 branch tests have some different config/limits compared to other branches?

@SanjalKatiyar
Copy link
Contributor

SanjalKatiyar commented Feb 20, 2024

Failed again for the same reason. Does the 4.13 branch tests have some different config/limits compared to other branches?

This passed: #48993, let's make release-4.13 config same as this "TEST" PR... I will close #48993 later...

@SanjalKatiyar
Copy link
Contributor

also, plz rebase ur PR with latest release master...

These 2 repos are unreleased product & have been long discontinued.
There tests are anyways failing without the cluster profile change so
removing them is prefered.

Signed-off-by: Malay Kumar Parida <[email protected]>
Signed-off-by: Malay Kumar Parida <[email protected]>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@malayparida2000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-red-hat-storage-odf-console-master-odf-console-e2e-aws red-hat-storage/odf-console presubmit Presubmit changed
pull-ci-red-hat-storage-odf-console-release-4.11-odf-console-e2e-aws red-hat-storage/odf-console presubmit Presubmit changed
pull-ci-red-hat-storage-odf-console-release-4.12-odf-console-e2e-aws red-hat-storage/odf-console presubmit Presubmit changed
pull-ci-red-hat-storage-odf-console-release-4.13-odf-console-e2e-aws red-hat-storage/odf-console presubmit Presubmit changed
pull-ci-red-hat-storage-odf-console-release-4.14-odf-console-e2e-aws red-hat-storage/odf-console presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-main-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.10-odf-operator-bundle-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.11-odf-operator-bundle-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.12-odf-operator-bundle-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.13-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.14-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.15-odf-operator-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-operator-release-4.9-odf-operator-bundle-e2e-aws red-hat-storage/odf-operator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-main-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.10-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.11-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.12-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.13-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.14-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.15-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.16-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.17-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.9-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Presubmit changed
pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws red-hat-storage/ocs-operator presubmit Presubmit changed
pull-ci-red-hat-storage-ocs-operator-release-4.10-ocs-operator-bundle-e2e-aws red-hat-storage/ocs-operator presubmit Presubmit changed

A total of 50 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws pull-ci-red-hat-storage-ocs-operator-release-4.15-ocs-operator-bundle-e2e-aws pull-ci-red-hat-storage-ocs-operator-release-4.14-ocs-operator-bundle-e2e-aws pull-ci-red-hat-storage-ocs-operator-release-4.13-ocs-operator-bundle-e2e-aws pull-ci-red-hat-storage-ocs-operator-release-4.12-ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-odf-operator-main-odf-operator-e2e-aws pull-ci-red-hat-storage-odf-operator-release-4.15-odf-operator-e2e-aws pull-ci-red-hat-storage-odf-operator-release-4.14-odf-operator-e2e-aws pull-ci-red-hat-storage-odf-operator-release-4.13-odf-operator-e2e-aws pull-ci-red-hat-storage-odf-operator-release-4.12-odf-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-odf-multicluster-orchestrator-main-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.17-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.16-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.15-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.14-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.13-integration-test pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.12-integration-test

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-odf-console-master-odf-console-e2e-aws pull-ci-red-hat-storage-odf-console-release-4.14-odf-console-e2e-aws pull-ci-red-hat-storage-odf-console-release-4.13-odf-console-e2e-aws pull-ci-red-hat-storage-odf-console-release-4.12-odf-console-e2e-aws

@malayparida2000
Copy link
Contributor Author

@SanjalKatiyar the odf-console tests are now passing here

@SanjalKatiyar
Copy link
Contributor

@SanjalKatiyar the odf-console tests are now passing here

LGTM.

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.17-integration-test

@malayparida2000
Copy link
Contributor Author

/pj-rehearse pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Feb 21, 2024

odf-multicluster-orchestrator-release-4.17-integration-test is failing for some unknown reason, as we have the deadline tomorrow and the test is for 4.17 branch we can not hold the PR anymore so please ignore that failure. ODF failures are acked by Nitin as already failing before this change due to other reasons. I will request to now please provide your approvals.

@agarwal-mudit @iamniting @SanjalKatiyar @umangachapagain

@malayparida2000
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 21, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@iamniting
Copy link
Member

/approve

2 similar comments
@SanjalKatiyar
Copy link
Contributor

/approve

@agarwal-mudit
Copy link
Contributor

/approve

Copy link
Contributor

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, iamniting, malayparida2000, naveenpaul1, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@malayparida2000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/red-hat-storage/mcg-ms-console/master/mcg-ms-console-e2e-aws a09878e link unknown /pj-rehearse pull-ci-red-hat-storage-mcg-ms-console-master-mcg-ms-console-e2e-aws
ci/rehearse/red-hat-storage/mcg-osd-deployer/main/test-suite a09878e link unknown /pj-rehearse pull-ci-red-hat-storage-mcg-osd-deployer-main-test-suite
ci/rehearse/red-hat-storage/odf-operator/release-4.11/odf-operator-bundle-e2e-aws a09878e link unknown /pj-rehearse pull-ci-red-hat-storage-odf-operator-release-4.11-odf-operator-bundle-e2e-aws
ci/rehearse/red-hat-storage/odf-operator/release-4.12/odf-operator-bundle-e2e-aws e3d2869 link unknown /pj-rehearse pull-ci-red-hat-storage-odf-operator-release-4.12-odf-operator-bundle-e2e-aws
ci/rehearse/red-hat-storage/odf-operator/release-4.14/odf-operator-e2e-aws e3d2869 link unknown /pj-rehearse pull-ci-red-hat-storage-odf-operator-release-4.14-odf-operator-e2e-aws
ci/rehearse/red-hat-storage/odf-operator/release-4.13/odf-operator-e2e-aws e3d2869 link unknown /pj-rehearse pull-ci-red-hat-storage-odf-operator-release-4.13-odf-operator-e2e-aws
ci/rehearse/red-hat-storage/odf-multicluster-orchestrator/release-4.17/integration-test e3d2869 link unknown /pj-rehearse pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.17-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cb43923 into openshift:master Feb 21, 2024
35 of 39 checks passed
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
…ft#48750)

* Delete ci-operator config for mcg-osd-deployer & mcg-ms-console repo

These 2 repos are unreleased product & have been long discontinued.
There tests are anyways failing without the cluster profile change so
removing them is prefered.

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for ocs-operator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-console repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-multicluster-orchestrator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-operator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Add make update changes

Signed-off-by: Malay Kumar Parida <[email protected]>

---------

Signed-off-by: Malay Kumar Parida <[email protected]>
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
…ft#48750)

* Delete ci-operator config for mcg-osd-deployer & mcg-ms-console repo

These 2 repos are unreleased product & have been long discontinued.
There tests are anyways failing without the cluster profile change so
removing them is prefered.

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for ocs-operator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-console repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-multicluster-orchestrator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Switch to odf-aws cluster profile for odf-operator repo

Signed-off-by: Malay Kumar Parida <[email protected]>

* Add make update changes

Signed-off-by: Malay Kumar Parida <[email protected]>

---------

Signed-off-by: Malay Kumar Parida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants