-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pao: move master jobs to 4.12 and remove tests #33526
Conversation
@yanirq: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I think we should do the move and the removal in two separate PRs. First the removal, then the move (but I don't really mind too much about the actual order) |
The removal is only from 4.12 |
ok, then we can perhaps address this by moving master and then removing the lanes? Anyway I'm not really blocking for this, the exact same reasoning (we had red lanes for quite some time) can also lead us to merge the two things together |
@@ -13,7 +13,7 @@ postsubmits: | |||
ci.openshift.io/generator: prowgen | |||
job-release: "4.11" | |||
max_concurrency: 1 | |||
name: branch-ci-openshift-kni-performance-addon-operators-master-images | |||
name: branch-ci-openshift-kni-performance-addon-operators-release-4.11-images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master should be renamed 4.12, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the 4.11 postsubmits job. there is another job for master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the filename as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, or maybe not, because there is a file right above this one that handles the master with 4.12 images...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an outcome of creating a 4.11 copy : https://github.com/openshift/release/pull/33526/files#diff-845d53be408e2b5ce81c7d5f2fa10af36677706373f9a2e68d54607a66c42350 from the master one.
Since we branched we should now have a 4.11 job added in addition to the master job
We still keep the must gather lane, right? |
@MarSik there is no specific test lane for must gather. we will need to add it once its completed under: openshift-kni/performance-addon-operators#943 |
/lgtm |
/hold |
move master jobs to point to 4.12. created 4.11 jobs for the new 4.11 pao upstream branch. removed from master the following tests and related images: e2e-gcp (for pao container and index images tests) e2e-gcp-operator-upgrade ci-ppc e2e-render-cmd all of the above are under cluster-node-tuning-operator. Signed-off-by: Yanir Quinn <[email protected]>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, marioferh, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yanirq: Updated the following 5 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
move master jobs to point to 4.12.
created 4.11 jobs for the new 4.11 pao upstream branch. removed from master the following tests and related images: e2e-gcp (for pao container and index images tests) e2e-gcp-operator-upgrade
ci-ppc
e2e-render-cmd
all of the above are under cluster-node-tuning-operator.
Signed-off-by: Yanir Quinn [email protected]