Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pao: move master jobs to 4.12 and remove tests #33526

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

yanirq
Copy link
Contributor

@yanirq yanirq commented Oct 27, 2022

move master jobs to point to 4.12.
created 4.11 jobs for the new 4.11 pao upstream branch. removed from master the following tests and related images: e2e-gcp (for pao container and index images tests) e2e-gcp-operator-upgrade
ci-ppc
e2e-render-cmd

all of the above are under cluster-node-tuning-operator.

Signed-off-by: Yanir Quinn [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

@yanirq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-kni/performance-addon-operators/release-4.11/e2e-gcp-operator-upgrade ff73ee13c36034361f7106f896e30ff043e3f6be link unknown /test pj-rehearse
ci/rehearse/openshift-kni/performance-addon-operators/release-4.11/e2e-gcp ff73ee13c36034361f7106f896e30ff043e3f6be link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Contributor

I think we should do the move and the removal in two separate PRs. First the removal, then the move (but I don't really mind too much about the actual order)

@yanirq
Copy link
Contributor Author

yanirq commented Oct 30, 2022

I think we should do the move and the removal in two separate PRs. First the removal, then the move (but I don't really mind too much about the actual order)

The removal is only from 4.12
The idea behind removing the test lanes in 4.12 (master) is to avoid bumping the version for these lanes since they are not really used and do the bump only for the relevant components.
4.11 was left intact and will not be cleared from the test lanes so we will always have a reference point

@ffromani
Copy link
Contributor

ffromani commented Nov 2, 2022

I think we should do the move and the removal in two separate PRs. First the removal, then the move (but I don't really mind too much about the actual order)

The removal is only from 4.12 The idea behind removing the test lanes in 4.12 (master) is to avoid bumping the version for these lanes since they are not really used and do the bump only for the relevant components. 4.11 was left intact and will not be cleared from the test lanes so we will always have a reference point

ok, then we can perhaps address this by moving master and then removing the lanes?
The lanes have been red for quite some time, one more overridden PR won't hurt.

Anyway I'm not really blocking for this, the exact same reasoning (we had red lanes for quite some time) can also lead us to merge the two things together

@@ -13,7 +13,7 @@ postsubmits:
ci.openshift.io/generator: prowgen
job-release: "4.11"
max_concurrency: 1
name: branch-ci-openshift-kni-performance-addon-operators-master-images
name: branch-ci-openshift-kni-performance-addon-operators-release-4.11-images
Copy link
Contributor

@Tal-or Tal-or Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master should be renamed 4.12, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the 4.11 postsubmits job. there is another job for master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the filename as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, or maybe not, because there is a file right above this one that handles the master with 4.12 images...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an outcome of creating a 4.11 copy : https://github.com/openshift/release/pull/33526/files#diff-845d53be408e2b5ce81c7d5f2fa10af36677706373f9a2e68d54607a66c42350 from the master one.
Since we branched we should now have a 4.11 job added in addition to the master job

@MarSik
Copy link
Contributor

MarSik commented Nov 2, 2022

We still keep the must gather lane, right?

@yanirq
Copy link
Contributor Author

yanirq commented Nov 2, 2022

We still keep the must gather lane, right?

@MarSik there is no specific test lane for must gather. we will need to add it once its completed under: openshift-kni/performance-addon-operators#943
which should also be done under the 4.11 and master branch for PAO repository (until we move must gather from there)
cc @marioferh

@ffromani
Copy link
Contributor

ffromani commented Nov 3, 2022

/lgtm

@ffromani
Copy link
Contributor

ffromani commented Nov 3, 2022

/hold
feel free to unhold when ready

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
move master jobs to point to 4.12.
created 4.11 jobs for the new 4.11 pao upstream branch.
removed from master the following tests and related images:
e2e-gcp (for pao container and index images tests)
e2e-gcp-operator-upgrade
ci-ppc
e2e-render-cmd

all of the above are under cluster-node-tuning-operator.

Signed-off-by: Yanir Quinn <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@ffromani
Copy link
Contributor

ffromani commented Nov 8, 2022

/approve
/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 8, 2022
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, marioferh, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7c8d30d into openshift:master Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

@yanirq: Updated the following 5 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-performance-addon-operators-master.yaml using file ci-operator/config/openshift-kni/performance-addon-operators/openshift-kni-performance-addon-operators-master.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-performance-addon-operators-release-4.11.yaml using file ci-operator/config/openshift-kni/performance-addon-operators/openshift-kni-performance-addon-operators-release-4.11.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-performance-addon-operators-master-presubmits.yaml using file ci-operator/jobs/openshift-kni/performance-addon-operators/openshift-kni-performance-addon-operators-master-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-performance-addon-operators-master-postsubmits.yaml using file ``
    • key openshift-kni-performance-addon-operators-release-4.11-postsubmits.yaml using file ci-operator/jobs/openshift-kni/performance-addon-operators/openshift-kni-performance-addon-operators-release-4.11-postsubmits.yaml
    • key openshift-kni-performance-addon-operators-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift-kni/performance-addon-operators/openshift-kni-performance-addon-operators-release-4.11-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_openshift-kni_quay using file core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay

In response to this:

move master jobs to point to 4.12.
created 4.11 jobs for the new 4.11 pao upstream branch. removed from master the following tests and related images: e2e-gcp (for pao container and index images tests) e2e-gcp-operator-upgrade
ci-ppc
e2e-render-cmd

all of the above are under cluster-node-tuning-operator.

Signed-off-by: Yanir Quinn [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants