Skip to content

OSD-29549 : Added unit test case for infra_node and controlplane_node under resize pkg #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amitupadh
Copy link
Contributor

This PR enhances test coverage and improves maintainability by adding unit test cases for the the resize package with dependency injection for better testability.

Coverage Details:
Increased unit test coverage for resize package

Verification:
All tests pass successfully, ensuring correctness and improved test coverage.

JIRA Ticket:

OSD-29549

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amitupadh
Once this PR has been reviewed and has the lgtm label, please assign typeid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amitupadh
Copy link
Contributor Author

/test all

@amitupadh amitupadh marked this pull request as ready for review April 30, 2025 08:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
@openshift-ci openshift-ci bot requested review from clcollins and dustman9000 April 30, 2025 08:43
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@amitupadh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 81dd018 link true /test test
ci/prow/format 81dd018 link true /test format

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant