Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: common.yaml: re-enable composefs on el9 #1735

Merged
merged 4 commits into from
Feb 14, 2025
Merged

NO-JIRA: common.yaml: re-enable composefs on el9 #1735

merged 4 commits into from
Feb 14, 2025

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Feb 3, 2025

The composefs issue (https://issues.redhat.com/browse/RHEL-63985)
should now be fixed in the latest el9 kernel. So let's optimistically
re-enable it. Now that we have tests for now, CI will validate this for
us as well.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@jlebon
Copy link
Member Author

jlebon commented Feb 3, 2025

/assign @travier

dustymabe
dustymabe reviewed Feb 3, 2025
View reviewed changes
common.yaml Outdated
if [ -f /usr/lib/ostree/prepare-root.conf ] && [[ $(rpm -q kernel) = *.el9.* ]]; then
grep -q 'enabled = true' /usr/lib/ostree/prepare-root.conf
sed -i -e 's,enabled = true,enabled = no,' /usr/lib/ostree/prepare-root.conf
sed -i -e 's,enabled = true,enabled = maybe,' /usr/lib/ostree/prepare-root.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled = maybe is definitely an interesting value to allow :(

dustymabe
dustymabe approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@jlebon
Copy link
Member Author

jlebon commented Feb 4, 2025

/retest

1 similar comment
@jlebon
Copy link
Member Author

jlebon commented Feb 6, 2025

/retest

@jlebon jlebon changed the title common.yaml: re-enable composefs on el9 NO-JIRA: common.yaml: re-enable composefs on el9 Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

The composefs issue (https://issues.redhat.com/browse/RHEL-63985)
should now be fixed in the latest el9 kernel. So let's optimistically
re-enable it. Now that we have tests for now, CI will validate this for
us as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dustymabe
Copy link
Member

looks like some of prow is still testing against 9.4. #1742 should handle some of the rework needed to stop that.

@dustymabe dustymabe mentioned this pull request Feb 10, 2025
Merged
@jlebon
Copy link
Member Author

jlebon commented Feb 10, 2025

Hmm, the ostree.sync error looks persistent.

 --- FAIL: ostree.sync (161.55s)
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs1/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs2/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs3/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs4/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs5/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs6/share failed, reason given by server: No such file or directory
        cluster.go:173: "for i in $(seq 6); do\n\t\t\tsudo mount -t nfs4 10.0.2.2:/var/nfs$i/share /var/tmp/data$i\n\t\t\tdone" failed: output , status Process exited with status 32

@HuijingHei do you know what's going on here? Looks like ostree.sync + composefs is failing. Though the error looks different from #1720.

@HuijingHei
Copy link
Contributor

HuijingHei commented Feb 12, 2025 •
edited
Loading

do you know what's going on here? Looks like ostree.sync + composefs is failing.

Can reproduce locally (add kernel argument ostree.prepare-root.composefs=1 in butane config in ostree.sync, refer to doc), will look at more about it.

@HuijingHei HuijingHei mentioned this pull request Feb 13, 2025
Closed
@jlebon
common.yaml: re-enable composefs on el9
b251ede 
The composefs issue (https://issues.redhat.com/browse/RHEL-63985) should
now be fixed in the latest el9 kernel. So let's optimistically re-enable
it. Now that we have tests for now, CI will validate this for us as
well.
@jlebon
denylist: drop 9.4-only entry
0f0474f 
We don't care about 9.4 anymore.
@jlebon
packages-openshift: use mountpoint instead of findmnt
2a3eaf6 
It's cleaner that way. Follow-up to 3f53dd3.
@jlebon
denylist: add ostree.sync on all arches
870c2ef 
That test is currently hitting issues when composefs is re-enabled:

openshift#1744

While we look into it, let's denylist it so we get more composefs
testing downstream.

Note there's already another entry for that same test on s390x, but
let's keep them separate since they seem to be separate issues.
@jlebon jlebon force-pushed the pr/composefs-reenable branch from f6d7094 to 870c2ef Compare February 13, 2025 14:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@jlebon
Copy link
Member Author

jlebon commented Feb 13, 2025

Rebased and added a denylist entry for ostree.sync for now!

@jlebon jlebon mentioned this pull request Feb 13, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025 •
edited
Loading

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-96-build-test-qemu f6d7094 link true /test rhcos-96-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member Author

jlebon commented Feb 13, 2025

/retest
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 13, 2025
@jlebon
Copy link
Member Author

jlebon commented Feb 13, 2025

/override ci/prow/e2e-aws
/override ci/prow/images

This will be fixed soon (coreos/fedora-coreos-pipeline#1091).

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/e2e-aws, ci/prow/images

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

This will be fixed soon (coreos/fedora-coreos-pipeline#1091).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jbtrystram
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jbtrystram, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,jbtrystram,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e1a1926 and 2 for PR HEAD 870c2ef in total

@openshift-merge-bot openshift-merge-bot bot merged commit b3e1fa1 into openshift:master Feb 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@aaradhak aaradhak Awaiting requested review from aaradhak

@gursewak1997 gursewak1997 Awaiting requested review from gursewak1997

Assignees

@dustymabe dustymabe

@jbtrystram jbtrystram

@travier travier

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlebon @openshift-ci-robot @dustymabe @HuijingHei @jbtrystram @travier