OSDOCS-13459#Add cross-subscription support for Azure File #92108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
|
🤖 Tue May 20 13:00:19 - Prow CI generated the docs preview: |
lpettyjo
added
branch/enterprise-4.19
peer-review-needed
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
added
the
peer-review-in-progress
mburke5678
reviewed
Apr 11, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-overview.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
mburke5678
reviewed
Apr 11, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
|
@lpettyjo A few suggestions. Otherwise LGTM |
mburke5678
removed
the
peer-review-in-progress
lpettyjo
force-pushed
the
OSDOCS-13459
branch
2 times, most recently
from
15688e3 to
af08584
Compare
duanwei33
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 12, 2025
modules/persistent-storage-csi-azure-file-cross-sub-dynamic-provisioning-procedure.adoc
Outdated
Show resolved
Hide resolved
lpettyjo
force-pushed
the
OSDOCS-13459
branch
2 times, most recently
from
1a5413b to
cc9e7f4
Compare
gcharot
reviewed
May 13, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
May 13, 2025
...s/persistent-storage-csi-azure-file-cross-sub-dynamic-pre-provisioning-pv-pvc-procedure.adoc
Show resolved
Hide resolved
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
lgtm |
|
LGTM |
1 similar comment
|
LGTM |
|
/cherrypick enterprise-4.19 |
|
@lpettyjo: new pull request created: #93820 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/OSDOCS-13459
Link to docs preview: https://92108--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-azure-file.html#persistent-storage-csi-azure-file-cross-sub-overview_persistent-storage-csi-azure-file
QE review:
Additional information:
PTAL: @gcharot @jsafrane @duanwei33