Skip to content

OSDOCS-14021#adding port info #92107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-14021#adding port info #92107

wants to merge 1 commit into from
+3 −1

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Apr 11, 2025 •
edited
Loading

Versions:
4.15+

Issue:
https://issues.redhat.com/browse/OSDOCS-14021

Link to docs preview:
This single update is displaying on these pages:

QE review:

  • QE has approved this change.

Additional information:

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 11, 2025 •
edited
Loading

🤖 Thu Apr 17 16:35:26 - Prow CI generated the docs preview:
https://92107--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@brendan-daly-red-hat
Copy link
Contributor Author

@sgaoshang, PTAL at the draft update.

@sgaoshang
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 17, 2025
@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 17, 2025
@opayne1 opayne1 added this to the Continuous Release milestone Apr 17, 2025
opayne1
opayne1 reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but other than that looks good to me! Also, could you check off that QE has approved? Thanks!

modules/installation-network-user-infra.adoc Outdated
@@ -159,6 +159,9 @@ the Cluster Version Operator on port `9099`.
|`10250`-`10259`
|The default ports that Kubernetes reserves

|`22623`
| The port handles the machine config server traffic and points to the control plane machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| The port handles the machine config server traffic and points to the control plane machines.
|The port handles traffic from the Machine Config Server and points to the control plane machines.

-Delete extra space

  • Machine Config Server should be capital
  • Small wording suggestion to the first part of sentence. Also, what do you think of changing the last part to "and directs the traffic to the control plane machines"

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 17, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2025

New changes are detected. LGTM label has been removed.

@brendan-daly-red-hat
OSDOCS-14021:adding new port
Loading
Loading status checks…
88914f3
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 25, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 25, 2025
lahinson
lahinson reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall for merge review. I'm not sure whether Machine Config Server should be capitalized, since I've seen it both lowercase and capitalized in the docs. I checked the OCP glossary and the SSG and didn't find any guidance there. I'd say go with whichever capitalization you see the most often to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opayne1 opayne1

@lahinson lahinson

Assignees

@sgaoshang sgaoshang

Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brendan-daly-red-hat @ocpdocs-previewbot @sgaoshang @opayne1 @lahinson