-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update loki-create-object-storage-secret-cli.adoc #92050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Incorrect command structure in Loki Object Storage documentation - Here is the doc link for AWS storage: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/logging/log-storage-4#loki-create-object-storage-secret-cli_installing-log-storage - the "-" signs are incorrectly placed below the "$" symbol. - However, they should be aligned parallel to the "oc" command, where the command begins. - Here is the updated look of the command: ~~~ $ oc create secret generic -n openshift-logging <your_secret_name> \ --from-file=tls.key=<your_key_file> --from-file=tls.crt=<your_crt_file> --from-file=ca-bundle.crt=<your_bundle_file> --from-literal=username=<your_username> --from-literal=password=<your_password> ~~~
🤖 Thu Apr 10 19:41:38 - Prow CI generated the docs preview: |
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hello @xenolinux , Regards, |
/label peer-review-needed |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; merging.
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
@sheriff-rh: new pull request created: #92183 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: new pull request created: #92184 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: new pull request created: #92185 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: new pull request created: #92186 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Incorrect command structure in Loki Object Storage documentation
Here is the doc link for AWS storage: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/logging/log-storage-4#loki-create-object-storage-secret-cli_installing-log-storage
the "-" signs are incorrectly placed below the "$" symbol.
However, they should be aligned parallel to the "oc" command, where the command begins.
Here is the updated look of the command:
Version(s):
RHOCP 4.16, RHOCP 4.15, RHOCP 4.14, RHOCP 4.13, RHOCP 4.12, RHOCP 4.11
Issue:
https://issues.redhat.com/browse/OBSDOCS-1837
Link to docs preview:
https://92050--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_storage/installing-log-storage.html
QE review:
Additional information: