Skip to content

Update loki-create-object-storage-secret-cli.adoc #92050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

prithvipatil97
Copy link
Contributor

@prithvipatil97 prithvipatil97 commented Apr 10, 2025

$ oc create secret generic -n openshift-logging <your_secret_name> \
  --from-file=tls.key=<your_key_file>
  --from-file=tls.crt=<your_crt_file>
  --from-file=ca-bundle.crt=<your_bundle_file>
  --from-literal=username=<your_username>
  --from-literal=password=<your_password>

Version(s):

RHOCP 4.16, RHOCP 4.15, RHOCP 4.14, RHOCP 4.13, RHOCP 4.12, RHOCP 4.11

Issue:

https://issues.redhat.com/browse/OBSDOCS-1837

Link to docs preview:

https://92050--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_storage/installing-log-storage.html

QE review:

  • QE has approved this change.

Additional information:

- Incorrect command structure in Loki Object Storage documentation
- Here is the doc link for AWS storage: 
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/logging/log-storage-4#loki-create-object-storage-secret-cli_installing-log-storage

- the "-" signs are incorrectly placed below the "$" symbol.
- However, they should be aligned parallel to the "oc" command, where the command begins.
- Here is the updated look of the command: 
~~~
$ oc create secret generic -n openshift-logging <your_secret_name> \
  --from-file=tls.key=<your_key_file>
  --from-file=tls.crt=<your_crt_file>
  --from-file=ca-bundle.crt=<your_bundle_file>
  --from-literal=username=<your_username>
  --from-literal=password=<your_password>
~~~
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2025
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Apr 10, 2025

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prithvipatil97
Copy link
Contributor Author

Hello @xenolinux ,
As discussed over another merged PR: #91680
We need to perform similar kinds of changes in the other object storage as well.
This PR is raised for the loki-create-object-storage-secret-cli object store.
Could you please take a look at this PR.
I will add a peer review label as well.

Regards,
Prithviraj Patil

@prithvipatil97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 11, 2025
@dfitzmau dfitzmau added branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 11, 2025
@dfitzmau dfitzmau added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 11, 2025
@prithvipatil97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 14, 2025
@sheriff-rh sheriff-rh added this to the Continuous Release milestone Apr 15, 2025
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 15, 2025
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; merging.

@sheriff-rh sheriff-rh merged commit 874b702 into openshift:enterprise-4.16 Apr 15, 2025
2 checks passed
@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #92183

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #92184

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #92185

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #92186

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants