Skip to content

OBSDOCS-1321: default thanos-ruler retention time should be 24h, not 15d #91990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

OBSDOCS-1321: default thanos-ruler retention time should be 24h, not 15d #91990

merged 1 commit into from
Apr 15, 2025
+1 −1

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Apr 10, 2025 •
edited
Loading

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview: ThanosRulerConfig

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 changed the title OBSDOCS-1321: default thanos-ruler retention time should be 24h, not … OBSDOCS#1321: default thanos-ruler retention time should be 24h, not 15d Apr 10, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2025
@openshift-ci-robot
Copy link

@eromanova97: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 changed the title OBSDOCS#1321: default thanos-ruler retention time should be 24h, not 15d OBSDOCS1321: default thanos-ruler retention time should be 24h, not 15d Apr 10, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2025
@eromanova97 eromanova97 changed the title OBSDOCS1321: default thanos-ruler retention time should be 24h, not 15d OBSDOCS-1321: default thanos-ruler retention time should be 24h, not 15d Apr 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

🤖 Thu Apr 10 12:17:49 - Prow CI generated the docs preview:

https://91990--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/config-map-reference-for-the-cluster-monitoring-operator.html
https://91990--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/config-map-reference-for-the-cluster-monitoring-operator.html
https://91990--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/observability/monitoring/config-map-reference-for-the-cluster-monitoring-operator.html
https://91990--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/config-map-reference-for-the-cluster-monitoring-operator.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 10, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview: [ThanosRulerConfig
]{https://91990--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/config-map-reference-for-the-cluster-monitoring-operator.html#thanosrulerconfig}

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview: ThanosRulerConfig

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 14, 2025
@juzhao
Copy link

juzhao commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17 and later

Issue: https://issues.redhat.com/browse/OBSDOCS-1321

Link to docs preview: ThanosRulerConfig

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 14, 2025
xenolinux
xenolinux reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 14, 2025
@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 15, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Apr 15, 2025
xenolinux
xenolinux reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merging

@xenolinux xenolinux merged commit 1d7c7cb into openshift:main Apr 15, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 15, 2025
@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.17

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.18

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #92167

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #92168

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #92169

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-1321 branch April 15, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees

@juzhao juzhao

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @juzhao @xenolinux @openshift-cherrypick-robot