Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIG-1664: MTC-1.8.5-release-notes #84677

Merged
merged 1 commit into from
Dec 11, 2024
Merged

MIG-1664: MTC-1.8.5-release-notes #84677

merged 1 commit into from
Dec 11, 2024

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Nov 8, 2024 •
edited by ShaunaDiaz
Loading

JIRA

Versions:

  • 4.14
  • 4.15
  • 4.16
  • 4.17
  • 4.18

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

JIRA

Versions:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 8, 2024 •
edited
Loading

🤖 Tue Dec 10 12:49:03 - Prow CI generated the docs preview:

https://84677--ocpdocs-pr.netlify.app/openshift-enterprise/latest/migration_toolkit_for_containers/release_notes/mtc-release-notes.html

@anarnold97
Copy link
Contributor Author

/label mtc

@openshift-ci openshift-ci bot added the MTC Label for all MTC PRs label Nov 27, 2024
rayfordj
rayfordj reviewed Dec 2, 2024
View reviewed changes
modules/migration-mtc-release-notes-1-8-5.adoc Outdated
Comment on lines 13 to 17
.Federal Information Processing Standard (FIPS)

Federal Information Processing Standards (FIPS) are a set of computer security standards developed by the United States federal government in line with the Federal Information Security Management Act (FISMA).

Starting with version {mtc-short} 1.8.5 is designed for FIPS compliance.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

NOTE: We'll want the same for 1.7.18's release notes.

anarnold97
anarnold97 commented Dec 2, 2024
View reviewed changes
modules/migration-mtc-release-notes-1-8-5.adoc Outdated

.Federal Information Processing Standard (FIPS)

Federal Information Processing Standards (FIPS) are a set of computer security standards developed by the United States federal government in line with the Federal Information Security Management Act (FISMA).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stillalearner & @rayfordj - should FIPS be a new feature or a known issue?
thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I find "technical changes" fitting, of those two choices, "new feature"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like FIPS in technical changes

@stillalearner - can you live with this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Versions:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stillalearner
stillalearner approved these changes Dec 5, 2024
View reviewed changes
Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akarol
Copy link

akarol commented Dec 6, 2024

@anarnold97 MTC 1.8.5 Known issues are not getting listed. seems like the filter needs an update in permissions.
otherwise lgtm

@anarnold97
Copy link
Contributor Author

@anarnold97 MTC 1.8.5 Known issues are not getting listed. seems like the filter needs an update in permissions. otherwise lgtm

@akarol - thanks very much. filter permissions updated:

image

@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 6, 2024
@shipsing
Copy link
Contributor

shipsing commented Dec 9, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 9, 2024
shipsing
shipsing reviewed Dec 9, 2024
View reviewed changes
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
modules/migration-mtc-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
@shipsing
Copy link
Contributor

shipsing commented Dec 9, 2024

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Dec 9, 2024
@anarnold97 anarnold97 force-pushed the MIG-1664-MTC-1.8.5-release-notes branch from e16ddae to d176257 Compare December 9, 2024 21:00
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 10, 2024
@anarnold97
Copy link
Contributor Author

anarnold97 commented Dec 10, 2024 •
edited
Loading

@jab-rh - sorry

  • 4.14
  • 4.15
  • 4.16
  • 4.17
  • 4.18

Thanks

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Versions:

  • 4.14,
  • 4.15,
  • 4.16
  • 4.17
  • 4.18

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Versions:

  • 4.14
  • 4.15
  • 4.16
  • 4.17
  • 4.18

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ShaunaDiaz
ShaunaDiaz reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/migration-mtc-release-notes-1-8-5.adoc

[id="mtc-resolved-issues-1-8-5_{context}"]
== Resolved issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

At some point when you're back here, you'll probably want to take out the extra line space.

modules/migration-mtc-release-notes-1-8-5.adoc

After changing the target namespace to something different from the source namespace while creating a `MigPlan` in the {mtc-short} UI, you cannot edit the `MigPlan` again to make the target namespace the same as the source namespace. link:https://issues.redhat.com/browse/MIG-1600[(MIG-1600)]


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Versions:

  • 4.14
  • 4.15
  • 4.16
  • 4.17
  • 4.18

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz merged commit 38de285 into openshift:main Dec 11, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.18

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.17

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #86092

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #86093

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #86094

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #86095

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #86096

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayfordj rayfordj rayfordj left review comments

@shipsing shipsing shipsing left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@stillalearner stillalearner stillalearner approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. MTC Label for all MTC PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.18 GA
Development

Successfully merging this pull request may close these issues.